Refactor: many changes to the object model of Reko.Core

* Moved src\Decompiler\IDecompiledFileService.cs to src\Decompiler\Services
* Moved src\Core\Services\IDecompilerUIService.cs to src\Gui\Services
* Sprinkled the [MaybeNullWhen] attribute on `out` parameters
* Removed one of the ExpressionEmitter.Slice overloads
* Updated the PublicAPI.Unshipped.txt file (still > 2000 API's to complete)

Author: uxmal

src/Arch/Alpha/AlphaArchitecture.cs

@@ -135,7 +135,7 @@ public override bool TryGetRegister(string name, [MaybeNullWhen(false)] out Regi
             return Registers.AllRegisters.TryGetValue(name, out reg);
         }
 
-        public override bool TryParseAddress(string? txtAddr, out Address addr)
+        public override bool TryParseAddress(string? txtAddr, [MaybeNullWhen(false)] out Address addr)
         {
             //$TODO: this should be in the platform not the architecture.
             return Address.TryParse32(txtAddr, out addr);

src/Arch/Alpha/AlphaRewriter.Alu.cs

@@ -149,7 +149,7 @@ private void RewriteSt(PrimitiveType dtFrom, PrimitiveType? dtTo = null)
             }
             else if (src.DataType != dtFrom)
             {
-                src = m.Slice(dtFrom, src, 0);
+                src = m.Slice(src, dtFrom);
             }
             var dst = Rewrite(instr.Operands[1]);
             dst.DataType = dtTo ?? dtFrom;
@@ -165,7 +165,7 @@ private void RewriteTrapb()
         private Expression addl(Expression a, Expression b)
         {
             return m.Convert(
-                m.Slice(PrimitiveType.Int32, m.IAdd(a, b), 0),
+                m.Slice(m.IAdd(a, b), PrimitiveType.Int32),
                 PrimitiveType.Int32,
                 PrimitiveType.Int64);
         }
@@ -216,8 +216,8 @@ private Expression mull(Expression a, Expression b)
 
             return m.Convert(
                 m.IMul(
-                    m.Slice(PrimitiveType.Int32, a, 0),
-                    m.Slice(PrimitiveType.Int32, b, 0)),
+                    m.Slice(a, PrimitiveType.Int32),
+                    m.Slice(b, PrimitiveType.Int32)),
                 PrimitiveType.Int32,
                 PrimitiveType.Int64);
         }
@@ -269,7 +269,7 @@ private Expression srl(Expression a, Expression sh)
         private Expression SExtend(Expression e)
         {
             return m.Convert(
-                m.Slice(PrimitiveType.Int32, e, 0),
+                m.Slice(e, PrimitiveType.Int32),
                 PrimitiveType.Int32,
                 PrimitiveType.Word64);
         }

src/Arch/Altera/Nios2Architecture.cs

@@ -26,6 +26,7 @@
 using Reko.Core.Types;
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 
 namespace Reko.Arch.Altera
 {
@@ -120,12 +121,12 @@ public override Address MakeAddressFromConstant(Constant c, bool codeAlign)
             throw new NotImplementedException();
         }
 
-        public override bool TryGetRegister(string name, out RegisterStorage reg)
+        public override bool TryGetRegister(string name, [MaybeNullWhen(false)] out RegisterStorage reg)
         {
             throw new NotImplementedException();
         }
 
-        public override bool TryParseAddress(string? txtAddr, out Address addr)
+        public override bool TryParseAddress(string? txtAddr, [MaybeNullWhen(false)] out Address addr)
         {
             return Address.TryParse32(txtAddr, out addr);
         }

src/Arch/Arc/ARCompactArchitecture.cs

@@ -169,7 +169,7 @@ public override bool TryGetRegister(string name, [MaybeNullWhen(false)] out Regi
             return Registers.ByName.TryGetValue(name, out reg);
         }
 
-        public override bool TryParseAddress(string? txtAddr, out Address addr)
+        public override bool TryParseAddress(string? txtAddr, [MaybeNullWhen(false)] out Address addr)
         {
             return Address.TryParse32(txtAddr, out addr);
         }

src/Arch/Arc/ARCompactRewriter.cs

@@ -530,7 +530,7 @@ private void MaybeSlice(Expression dst, Expression src)
             var bitDiff = src.DataType.BitSize - dst.DataType.BitSize;
             if (bitDiff > 0)
             {
-                src = m.Slice(dst.DataType, src, 0);
+                src = m.Slice(src, dst.DataType);
             }
             m.Assign(dst, src);
         }
@@ -675,7 +675,7 @@ private void RewriteDivaw()
 
         private void RewriteExt(PrimitiveType dtSlice, PrimitiveType dtExt)
         {
-            var src = m.Slice(dtSlice, Operand(1), 0);
+            var src = m.Slice(Operand(1), dtSlice);
             var dst = Operand(0);
             m.Assign(dst, m.Convert(src, src.DataType, dtExt));
         }

src/Arch/Arc/ArcDisassembler.cs

@@ -1107,7 +1107,7 @@ Decoder JLcc(bool delay)
                     (0x01, Instr(Mnemonic.push_s, b)),
                     (0x11, Instr(Mnemonic.push_s, blink))));
 
-            var GpBasedInstructions = Mask(9, 2, "  19 LD_S / LDW_S / LDB_S / ADD_S  Gp-based ld/add (data aligned offset) 16-bit",
+            var GpBasedInstructions = Mask(9, 2, "  19 LD_S / LDW_S / LDB_S / ADD_S  Gp-based ld/add (data aligned Offset) 16-bit",
                 Instr(Mnemonic.ld_s, r0, Mo_reg_s(PrimitiveType.Word32, Registers.Gp, 9)),
                 Instr(Mnemonic.ldb_s, r0, Mo_reg_s(PrimitiveType.Byte, Registers.Gp, 9)),
                 Instr(Mnemonic.ldw_s, r0, Mo_reg_s(PrimitiveType.Word16, Registers.Gp, 9)),
@@ -1127,14 +1127,14 @@ Decoder JLcc(bool delay)
                     Mask(4, 1, "    BLcc 1?",
                         breq,
                         Nyi("    BLcc 11")))),
-                new W32Decoder(Mask(7, 2, "  02 LD register + offset Delayed load 32-bit",
+                new W32Decoder(Mask(7, 2, "  02 LD register + Offset Delayed load 32-bit",
                     Mask(6, 1, "  X - sign extension",
                         Instr(Mnemonic.ld, A, AA9, Di11, Mo(PrimitiveType.Word32, Bf((12, 3), (24, 3)), Bf((15, 1), (16, 7)))),
                         invalid),
                     Instr(Mnemonic.ldb, A, AA9, Di11, X, Mo(PrimitiveType.Word32, Bf((12, 3), (24, 3)), Bf((15, 1), (16, 7)))),
                     Instr(Mnemonic.ldw, A, AA9, Di11, X, Mo(PrimitiveType.Word32, Bf((12, 3), (24, 3)), Bf((15, 1), (16, 7)))),
                     invalid)),
-                new W32Decoder(Mask(1, 2, "  03 ST register + offset Buffered store 32-bit",
+                new W32Decoder(Mask(1, 2, "  03 ST register + Offset Buffered store 32-bit",
                     Instr(Mnemonic.st, C, AA3, Di5, Mo(PrimitiveType.Word32, Bf((12, 3), (24, 3)), Bf((15, 1), (16, 7)))),
                     Instr(Mnemonic.stb, C, AA3, Di5, Mo(PrimitiveType.Word32, Bf((12, 3), (24, 3)), Bf((15, 1), (16, 7)))),
                     Instr(Mnemonic.stw, C, AA3, Di5, Mo(PrimitiveType.Word32, Bf((12, 3), (24, 3)), Bf((15, 1), (16, 7)))),
@@ -1209,7 +1209,7 @@ Decoder JLcc(bool delay)
                 Instr(Mnemonic.ld_s, c, Mo_s(PrimitiveType.Word16)),
                 Instr(Mnemonic.ldb_s, c, Mo_s(PrimitiveType.Word16)),
                 Instr(Mnemonic.ldw_s, c, Mo_s(PrimitiveType.Word16)),
-                Nyi("  13 LDW_S.X c,[b,u6] Delayed load (16-bit aligned offset) 16-bit"),
+                Nyi("  13 LDW_S.X c,[b,u6] Delayed load (16-bit aligned Offset) 16-bit"),
 
                 Instr(Mnemonic.st_s, c, Mo_s(PrimitiveType.Word32)),
                 Instr(Mnemonic.stb_s, c, Mo_s(PrimitiveType.Word32)),

src/Arch/Arm/AArch32/ArmRewriter.Alu.cs

@@ -160,7 +160,7 @@ private void RewriteRevsh()
             var intrinsic = m.Convert(
                 m.Fn(
                     rev_intrinsic.MakeInstance(PrimitiveType.Word16),
-                    m.Slice(PrimitiveType.Word16, this.Operand(1), 0)),
+                    m.Slice(this.Operand(1), PrimitiveType.Word16)),
                 PrimitiveType.Word16,
                 PrimitiveType.Int32);
             m.Assign(opDst, intrinsic);
@@ -432,7 +432,7 @@ private void RewriteStr(PrimitiveType size)
             var opDst = this.Operand(1);
             if (size != PrimitiveType.Word32)
             {
-                opSrc = m.Slice(size, opSrc, 0);
+                opSrc = m.Slice(opSrc, size);
             }
             m.Assign(opDst, opSrc);
             MaybePostOperand(1);
@@ -858,8 +858,8 @@ private void RewriteSmusd()
             var rm = this.Operand(2);
             var p1 = binder.CreateTemporary(PrimitiveType.Int32);
             var p2 = binder.CreateTemporary(PrimitiveType.Int32);
-            m.Assign(p1, m.SMul(m.Slice(s16, rn, 0), m.Slice(s16, rm, 0)));
-            m.Assign(p2, m.SMul(m.Slice(s16, rn, 16), m.Slice(s16, rm, 16)));
+            m.Assign(p1, m.SMul(m.Slice(rn, s16, 0), m.Slice(rm, s16, 0)));
+            m.Assign(p2, m.SMul(m.Slice(rn, s16, 16), m.Slice(rm, s16, 16)));
             m.Assign(dst, m.ISub(p1, p2));
         }
 
@@ -1091,7 +1091,7 @@ private void RewriteXtab(PrimitiveType dt)
             Expression src = Operand(2);
             if (dt.BitSize < src.DataType.BitSize)
             {
-                src = m.Slice(dt, src, 0);
+                src = m.Slice(src, dt);
             }
             src = m.Convert(src, src.DataType, dst.DataType);
             m.Assign(dst, m.IAdd(this.Operand(1), src));
@@ -1103,7 +1103,7 @@ private void RewriteXtb(PrimitiveType dtSrc, PrimitiveType dtDst)
             Expression src = Operand(1);
             if (dtSrc.BitSize < src.DataType.BitSize)
             {
-                src = m.Slice(dtSrc, src, 0);
+                src = m.Slice(src, dtSrc);
             }
             src = m.Convert(src, dtSrc, dtDst);
             m.Assign(dst, src);

src/Arch/Arm/AArch32/ArmRewriter.cs

@@ -1052,7 +1052,7 @@ void RewriteSwp(PrimitiveType type)
         private Expression EmitNarrowingSlice(Expression e, DataType dt)
         {
             var tmp = binder.CreateTemporary(dt);
-            m.Assign(tmp, m.Slice(dt, e, 0));
+            m.Assign(tmp, m.Slice(e, dt));
             return tmp;
         }
 

src/Arch/Arm/AArch32/T32Disassembler.cs

@@ -2434,7 +2434,7 @@ private static LongDecoder CreateLongDecoder()
                 invalid,
                 invalid);
 
-            var LoadStoreUnsignedRegisterOffset = Mask(4 + 16, 3, "Load/store, unsigned (register offset)",
+            var LoadStoreUnsignedRegisterOffset = Mask(4 + 16, 3, "Load/store, unsigned (register Offset)",
                 Instr(Mnemonic.strb, R12,MemIdx(PrimitiveType.Byte,16,0,(4,2))),
                 Select((16, 4), n => n != 0xF,
                     Instr(Mnemonic.ldrb, wide,R12,MemIdx(PrimitiveType.Byte,16,0,(4,2))),
@@ -2507,7 +2507,7 @@ private static LongDecoder CreateLongDecoder()
                     invalid));
 
             var LoadStoreSignedRegisterOffset = Select((12,4), n => n != 0xF,
-                Mask(5 + 16, 2, "Load/store, signed (register offset)",
+                Mask(5 + 16, 2, "Load/store, signed (register Offset)",
                     Instr(Mnemonic.ldrsb, wide, R12, MemIdx(PrimitiveType.SByte, 16, 0, (4, 2))),
                     Instr(Mnemonic.ldrsh, wide, R12, MemIdx(PrimitiveType.Int16, 16, 0, (4, 2))),
                     invalid,
@@ -2579,9 +2579,9 @@ private static LongDecoder CreateLongDecoder()
                             invalid,
                             invalid, 
 
-                            Instr(Mnemonic.stc, nyi("*offset variant")),
+                            Instr(Mnemonic.stc, nyi("*Offset variant")),
                             Select((16,4), n => n != 15,
-                                Instr(Mnemonic.ldc, nyi("*offset variant")),
+                                Instr(Mnemonic.ldc, nyi("*Offset variant")),
                                 ldc_literal),
                             Instr(Mnemonic.stc, nyi("*preindexed variant")),
                             Select((16,4), n => n != 15,
@@ -2590,7 +2590,7 @@ private static LongDecoder CreateLongDecoder()
 
                             Instr(Mnemonic.stc, CPn14,CR12,MemOff(PrimitiveType.Word32, 16, offsetShift:2, offsetFields:(0,8))),
                             Select((16,4), n => n != 15,
-                                Instr(Mnemonic.ldc, nyi("*offset variant")),
+                                Instr(Mnemonic.ldc, nyi("*Offset variant")),
                                 ldc_literal),
                             Instr(Mnemonic.stc, nyi("*preindexed variant")),
                             Select((16,4), n => n != 15,

src/Arch/Arm/AArch64.cs

@@ -253,7 +253,7 @@ public override Address MakeAddressFromConstant(Constant c, bool codeAlign)
             return Address.Ptr64(uAddr);
         }
 
-        public override bool TryParseAddress(string? txtAddress, out Address addr)
+        public override bool TryParseAddress(string? txtAddress, [MaybeNullWhen(false)] out Address addr)
         {
             return Address.TryParse64(txtAddress, out addr);
         }