Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add units library to repo #312

Open
younesr1 opened this issue Mar 5, 2021 · 3 comments
Open

Add units library to repo #312

younesr1 opened this issue Mar 5, 2021 · 3 comments
Assignees

Comments

@younesr1
Copy link
Contributor

younesr1 commented Mar 5, 2021

Investigate using a units library like this
https://github.com/nholthaus/units

it would simplify function names like readAngleDegPerSec() and constants like maxRPM, and will generally be safer

@wmmc88 @cindyli-13 thoughts? this could be an easy task for new members

@wmmc88
Copy link
Member

wmmc88 commented Mar 5, 2021

I'd prefer to just standardize units instead. Like ros has a REP that standardizes everything.

@cindyli-13
Copy link
Member

I'm fine with either units library or standardizing units, as long as we're consistent throughout the whole repo

@younesr1
Copy link
Contributor Author

younesr1 commented Mar 5, 2021

@upadhyaydhruv for starters, create a units library and write a test-units app the shows how to use these units: Amperes, Degrees, Degrees per sec, Newtons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants