Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable inclusion of trash can / delete #163

Open
mcjustin opened this issue Nov 30, 2022 · 2 comments
Open

configurable inclusion of trash can / delete #163

mcjustin opened this issue Nov 30, 2022 · 2 comments

Comments

@mcjustin
Copy link
Member

... and configure this to be "off" for DCW.

@achen2401
Copy link
Contributor

@mcjustin @pbugni @ivan-c
With this PR, the appearance of trash can/delete icon is governed by the configuration variable, ENABLE_PATIENT_DELETE. Setting the variable to true will make the icon appear. The default value for the configuration variable is currentlyfalse - meaning that the trashcan icon won't be present by default. It means that we will need to set the variable to true for COSRI.. Or should the configuration variable has a true value by default so the trashcan icon is present by default?

@mcjustin
Copy link
Member Author

mcjustin commented Dec 7, 2022

@mcjustin @pbugni @ivan-c With this PR, the appearance of trash can/delete icon is governed by the configuration variable, ENABLE_PATIENT_DELETE. Setting the variable to true will make the icon appear. The default value for the configuration variable is currentlyfalse - meaning that the trashcan icon won't be present by default. It means that we will need to set the variable to true for COSRI.. Or should the configuration variable has a true value by default so the trashcan icon is present by default?

I prefer a default of false for this, since the delete operation is rather undefined and dangerous (COSRI has a special carve-out since it can rely on the PDMP for re-population of most data).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants