New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`wait_until_pending_actions_complete`: docs and use in `orchestrator_rosbag_player` wrong #7

Open

ottojo opened this issue Feb 5, 2024 · 0 comments

Collaborator

ottojo commented Feb 5, 2024

Function does not block, as specified in docs, but return a future that must be awaited: https://github.com/uulm-mrm/ros2_def/blob/develop/ros2/orchestrator/orchestrator/orchestrator_lib/orchestrator.py#L459

Incorrect use in rosbag player: https://github.com/uulm-mrm/ros2_def/blob/develop/ros2/orchestrator_rosbag_player/orchestrator_rosbag_player/rosbag_player.py#L140

Perhaps add typechecker attribute to prevent discarding return value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment