Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-format check fails to identify commit, leading to false CI passes #647

Open
suzuki-toshihir0 opened this issue Jun 7, 2024 · 0 comments
Assignees
Labels
patch backwards compatible bug fixes priority::medium priority medium tools

Comments

@suzuki-toshihir0
Copy link
Member

Details

There is an issue where clang-format in CI cannot correctly identify the commit when a commit is added to a pull request, causing the clang-format check not to run. The workflow that checks clang-format relies on whether there is a diff to determine OK/NG. However, if clang-format fails to identify the commit, the CI passes even though clang-format did not run. This issue can be observed in the following example: https://github.com/ut-issl/s2e-core/actions/runs/9396464963/job/25877704595?pr=639#step:6:5.

Closing conditions

The issue should be resolved by fixing the clang-format check workflow to ensure that it correctly identifies commits and runs clang-format properly, preventing the CI from passing when clang-format has not been executed.

Supplementary information

  • N/A

Note

  • N/A
@suzuki-toshihir0 suzuki-toshihir0 added priority::medium priority medium tools patch backwards compatible bug fixes labels Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch backwards compatible bug fixes priority::medium priority medium tools
Projects
Status: 🔲 Todo
Development

No branches or pull requests

2 participants