Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical slice for visualizer #17

Open
delongchamp opened this issue Aug 31, 2024 · 0 comments
Open

Vertical slice for visualizer #17

delongchamp opened this issue Aug 31, 2024 · 0 comments
Labels
enhancement New feature or request hackathon_2024 appropriate issues for RSoXS hackathon Sep 3-6, 2024

Comments

@delongchamp
Copy link
Collaborator

delongchamp commented Aug 31, 2024

The visualize_materials method uses the morphology_visualizer function to produce a visualization of composition and orientation of the model within the morphology object.

Currently, the library only supports visualization of horizontal slices. This can make visualization checks difficult when meaningful structure is included in the z-direction. A vertical modality for visualization would be a significant enhancement.

TODO:

  • Construct and integrate a vertical visualization modality
  • To avoid breaking changes, it may make sense to create this as a separate method from the current visualize_materials, which has a crazy number of optional arguments aleady.
  • The style of the plots should match existing visualizer, and similar optional arguments should be provided.

IMPORTANT:
The visualization modules of the NRSS MUST be bugproof and heavily vetted. Users will rely on them as the ground truth of what was simulated. User experience strongly suggests that mistakes with regard to algorithmically created morphologies - specifically misunderstandings about what the morphologies actually contain - are one of the principal sources of error, confusion, and lost time with NRSS workflows. A visualization with any potential to lie to the user would be worse than no visualization.

@delongchamp delongchamp added enhancement New feature or request hackathon_2024 appropriate issues for RSoXS hackathon Sep 3-6, 2024 labels Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hackathon_2024 appropriate issues for RSoXS hackathon Sep 3-6, 2024
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant