Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_parser is unmaintained #184

Closed
itrofimow opened this issue Nov 1, 2022 · 3 comments
Closed

http_parser is unmaintained #184

itrofimow opened this issue Nov 1, 2022 · 3 comments
Labels
good first issue Good small issue for newcomers help wanted We would appreciate PR

Comments

@itrofimow
Copy link
Contributor

See nodejs/http-parser#522

There is https://github.com/nodejs/llhttp with very similar API (although llhttp is missing the URL parser functions from http-parser), so we could switch to it pretty easily, and it also promises massive perf improvements

@apolukhin apolukhin added help wanted We would appreciate PR big A big feature labels Nov 5, 2022
@apolukhin
Copy link
Member

apolukhin commented Nov 5, 2022

Sound great. But we have to keep supporting http_parser as long as most of the distros do not get support for the llhttp

@itrofimow
Copy link
Contributor Author

itrofimow commented Nov 5, 2022

We can vendor it in third_party, and thats what most people who switched do - llhttp has c sources in releases .tar since v6 or smth, so it should be as easy as FetchContent: https://github.com/nodejs/llhttp#using-with-cmake

@apolukhin apolukhin added good first issue Good small issue for newcomers and removed big A big feature labels Nov 5, 2022
@itrofimow
Copy link
Contributor Author

Addressed by e6b635c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good small issue for newcomers help wanted We would appreciate PR
Projects
None yet
Development

No branches or pull requests

2 participants