Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu/debian based commons image #1181

Open
shreddedbacon opened this issue Dec 4, 2024 · 2 comments
Open

Ubuntu/debian based commons image #1181

shreddedbacon opened this issue Dec 4, 2024 · 2 comments

Comments

@shreddedbacon
Copy link
Member

Would there be potential benefits to having a commons image that is ubuntu/debian based?

While I was messing around with trying to run some custom images built from ubuntu with Lagoon, I hit some stumbling blocks that could probably be simplified by having a supported commons image.

If we look at how we set up the nginx image here we copy in 4 directories from commons.

But if we look at the solr image here we copy in only 3, excluding the tini directory, because that gets downloaded in a later step

To standardise the copy process, it seems like simply having commons build an ubuntu base could help reduce that.

Additionally, steps like installing applications could potentially have a command wrapper that could be added to commons so that duplication of commands like this and this could be something like

RUN install-packages busybox curl rsync tar zip

Which would just run apk or apt in the background, with the user only having to specify the commons as the base.

Then could stuff like this be added to commons as a command wrapper like fix-dash

@tobybellwood
Copy link
Member

I've got an old branch that did just this - I can see if I can resurrect it.

The one update is that as bookworm rolls out more widely, dash support for emulating bash is removed (as per #1155) - so it might become simpler again!

@shreddedbacon
Copy link
Member Author

Sweet. Not an urgent thing by any means. And I may have feature creeped beyond the issue title with the consolidated commands thing. But I think these sorts of wrappers to simplify re-use could be beneficial in things like documenting what they do in terms of helping an image be "lagoonized"

Where we can document things like this

When creating a custom image, you can incorporate common components from Lagoon using X, Y, Z.

X performs these functions which bring in common entrypoints that solve X problems
Y are scripts that help you install packages
Z are scripts that help you fix any potential permissions issues, or set up environments in a way that helps

And because the scripts would be in commons, they could be adjusted to suit alpine or debian, but the entrypoint to both are the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants