-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String Interpolation #1460
Comments
I have a working PR. @nelup20 @martinsefcik @Its-treason @mirkogolze Requesting Review. |
I have integrated the new common interpolation librray with App, Electron and CLI. Have also started maintain a test suite via a collection that is also run as a part of github action Also happy to bid adieu to Handlebars. We were clearly shoehorning our use case into it. The new interpolation function has extensive tests cases matching our requirements and we can keep adding more cases in the future. |
String Interpolation
Goal
Today our interpolation logic is duplicated across multiple packages (App, Electron, CLI)
The goal is to centralize a single source of truth for all interpolation logic.
Considerations
Moving away from handlebars
I think its time to move away from handlebars.
We don't need the full power of handlebars and we want write a custom interpolation function that meets our needs instead of shoehorning handlebars to match our use case.
Related Tickets
The text was updated successfully, but these errors were encountered: