-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media structs are prefixed with onvif: #29
Comments
After investigating further, I think the issue is that the xml spec defined in |
Hi @guo1017138, so we ended up forking the repo and I can give you some insights as to what is happening. There is two issues:
I hope that helps you! |
@wfotiuk Thanks for the nice suggestion/solution. My private change solution is almost the same with you, especially for item 2. I will apply item 1 also to make it more perfect! |
Right on! I am going to be looking into putting up some PRs getting this stuff into the main repo if possible. |
I faced similar problems and also ended up forking the repo. I opened #27 some time ago with some other general fixes. |
would love to see you changes, if you have some already can you please share that |
I can! I have created my own fork of it and I have to talk to my boss to
see what we can share. I'll get back to you!
…On Sun, Aug 27, 2023 at 10:48 PM Pawan-ky ***@***.***> wrote:
Right on! I am going to be looking into putting up some PRs getting this
stuff into the main repo if possible.
@wfotiuk <https://github.com/wfotiuk>
would love to see you changes, if you have some already can you please
share that
—
Reply to this email directly, view it on GitHub
<#29 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYXHQWPUEQ42ETQYSTLMK3XXQWJZANCNFSM6AAAAAARDNNQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
-Wally Fotiuk
|
I can share everything I think but I have altered the repo quite a bit.
Maybe we can have a meeting to go over the changes if you have time. I
added generated tests for the generated functions and had to change some
structures because they would serialize fine but break when deserializing.
I can compile a list of the changes and we can incorporate what we want to
go into the main trunk. I do think all of the changes were necessary to
make the repo functional
…On Mon, Aug 28, 2023 at 11:16 AM Wally Fotiuk ***@***.***> wrote:
I can! I have created my own fork of it and I have to talk to my boss to
see what we can share. I'll get back to you!
On Sun, Aug 27, 2023 at 10:48 PM Pawan-ky ***@***.***>
wrote:
> Right on! I am going to be looking into putting up some PRs getting this
> stuff into the main repo if possible.
>
> @wfotiuk <https://github.com/wfotiuk>
>
> would love to see you changes, if you have some already can you please
> share that
>
> —
> Reply to this email directly, view it on GitHub
> <#29 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAYXHQWPUEQ42ETQYSTLMK3XXQWJZANCNFSM6AAAAAARDNNQGI>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
-Wally Fotiuk
--
-Wally Fotiuk
|
So I noticed when trying to use the media queries (sdk/media/*), that some of the structs are prefixed by
onvif:
for the xml parsing tags (example https://github.com/use-go/onvif/blob/master/xsd/onvif/onvif.go#L361).When getting an actual response from a camera, I noticed the structs did not unmarshal properly because of this prefix. From my understanding, the prefixes should be different according to the ONVIF media spec.
Regardless, I have forked the repo and dropped the prefix for my uses, but was curious if you would like a PR and the tests I wrote, or if I am headed in the wrong direction
The text was updated successfully, but these errors were encountered: