Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StandardShaderBall: Light interpretation variant #81

Open
pablode opened this issue Feb 23, 2024 · 1 comment
Open

StandardShaderBall: Light interpretation variant #81

pablode opened this issue Feb 23, 2024 · 1 comment

Comments

@pablode
Copy link
Contributor

pablode commented Feb 23, 2024

Currently, light units and how values are interpreted vary between different renderers and Hydra-enabled applications (as can be seen in this repository), causing the shader ball to most likely only render correctly in the environment it was authored in (Karma).

In order to get comparable results in other environments, we could add a variant that overrides the specific light properties, like intensities with values that have been calculated based on the original values. The logic could be based on above investigation and perhaps this PR can provide additional information.

More specifically, it would also make sense to include (and perhaps default to) the proposed update of the UsdLux specification.

@crydalch
Copy link
Contributor

Yes when the UsdLux proposals are accepted and light units/behaviors are better defined, we plan to update the scene to use those by default. It's probably not useful to keep the old, "wild-west" of light unit interpretations around once UsdLux is more rigorous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants