Fix: Increase test coverage

Author: dearchap

command_test.go

@@ -3975,6 +3975,21 @@ func TestZeroValueCommand(t *testing.T) {
 	assert.NoError(t, cmd.Run(context.Background(), []string{"foo"}))
 }
 
+func TestCommandInvalidName(t *testing.T) {
+	var cmd Command
+	assert.Equal(t, int64(0), cmd.Int("foo"))
+	assert.Equal(t, uint64(0), cmd.Uint("foo"))
+	assert.Equal(t, float64(0), cmd.Float("foo"))
+	assert.Equal(t, "", cmd.String("foo"))
+	assert.Equal(t, time.Time{}, cmd.Timestamp("foo"))
+	assert.Equal(t, time.Duration(0), cmd.Duration("foo"))
+
+	assert.Equal(t, []int64(nil), cmd.IntSlice("foo"))
+	assert.Equal(t, []uint64(nil), cmd.UintSlice("foo"))
+	assert.Equal(t, []float64(nil), cmd.FloatSlice("foo"))
+	assert.Equal(t, []string(nil), cmd.StringSlice("foo"))
+}
+
 func TestJSONExportCommand(t *testing.T) {
 	cmd := buildExtendedTestCommand()
 	cmd.Arguments = []Argument{

flag_float_slice.go

@@ -1,9 +1,5 @@
 package cli
 
-import (
-	"flag"
-)
-
 type (
 	FloatSlice     = SliceBase[float64, NoConfig, floatValue]
 	FloatSliceFlag = FlagBase[[]float64, NoConfig, FloatSlice]
@@ -14,22 +10,11 @@ var NewFloatSlice = NewSliceBase[float64, NoConfig, floatValue]
 // FloatSlice looks up the value of a local FloatSliceFlag, returns
 // nil if not found
 func (cmd *Command) FloatSlice(name string) []float64 {
-	if flSet := cmd.lookupFlagSet(name); flSet != nil {
-		return lookupFloatSlice(name, flSet, cmd.Name)
-	}
-
-	return nil
-}
-
-func lookupFloatSlice(name string, set *flag.FlagSet, cmdName string) []float64 {
-	fl := set.Lookup(name)
-	if fl != nil {
-		if v, ok := fl.Value.(flag.Getter).Get().([]float64); ok {
-			tracef("float slice available for flag name %[1]q with value=%[2]v (cmd=%[3]q)", name, v, cmdName)
-			return v
-		}
+	if v, ok := cmd.Value(name).([]float64); ok {
+		tracef("float slice available for flag name %[1]q with value=%[2]v (cmd=%[3]q)", name, v, cmd.Name)
+		return v
 	}
 
-	tracef("float slice NOT available for flag name %[1]q (cmd=%[2]q)", name, cmdName)
+	tracef("float slice NOT available for flag name %[1]q (cmd=%[2]q)", name, cmd.Name)
 	return nil
 }