Skip to content
This repository has been archived by the owner on Apr 16, 2023. It is now read-only.

Clean up app code #104

Open
gsganden opened this issue Aug 4, 2019 · 3 comments
Open

Clean up app code #104

gsganden opened this issue Aug 4, 2019 · 3 comments
Labels
good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed

Comments

@gsganden
Copy link
Collaborator

gsganden commented Aug 4, 2019

The code in autofocus/predict works, but it was written in a hurry and would probably benefit from some careful attention.

@jameslamb jameslamb added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 29, 2019
@DigitalPhilosopher
Copy link

DigitalPhilosopher commented Oct 15, 2019

Hey, I have tried to clean up and organize the code in predict. I would like to open a new branch and push to it, but it seems that I do not have the permission to do that.

I've also managed to find and close some bugs:

  • The zip is removed from the server after completion
  • The complete zip is now analyzed (before it returned within the loop)

@gsganden
Copy link
Collaborator Author

Awesome!

Sorry, the PR process needs a bit of cleanup and documentation. Please create a fork and submit your PR against the dev branch. LMK if you run into any issues.

@DigitalPhilosopher
Copy link

DigitalPhilosopher commented Oct 16, 2019

Perfect, thank you. I created the PR now. After a few changes the build is now running on travis.

One side note: Since there was the bug in the loop at the predict_zip endpoint, the running PR takes all files instead or running a loop. I think the better solution here would be to add a method in ZipFile named apply, which can apply a method on all the files in the zip file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants