From e0de9d8bcd3924b0289f77642f9b3c88b052806c Mon Sep 17 00:00:00 2001
From: Harry Lewis <harry@upmind.com>
Date: Wed, 25 Sep 2024 18:28:12 +0100
Subject: [PATCH] Update OpenProvider error handling, return api response data
 in provision result data

---
 src/OpenProvider/Provider.php | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/src/OpenProvider/Provider.php b/src/OpenProvider/Provider.php
index ad5e890..a9d04c2 100644
--- a/src/OpenProvider/Provider.php
+++ b/src/OpenProvider/Provider.php
@@ -649,13 +649,13 @@ protected function _callApi(array $params, string $path, string $method = 'GET',
     protected function _handleApiErrorResponse(Response $response, $responseData): void
     {
         $errorData = [
-            'http_code' => $response->getStatusCode()
+            'http_code' => $response->getStatusCode(),
+            'response_data' => $responseData,
         ];
 
         if (!isset($responseData['code'])) {
-            throw $this->errorResult('Unexpected provider response', $errorData, [
-                'response_body' => $response->getBody()->__toString(),
-            ]);
+            $errorData['response_body'] = $response->getBody()->__toString();
+            $this->errorResult('Unexpected provider response', $errorData);
         }
 
         $message = 'Provider Error: ';
@@ -676,9 +676,7 @@ protected function _handleApiErrorResponse(Response $response, $responseData): v
                 $message .= ($responseData['desc'] ?? 'Unknown error');
         }
 
-        throw $this->errorResult($message, $errorData, [
-            'response_data' => $responseData,
-        ]);
+        $this->errorResult($message, $errorData);
     }
 
     protected function _getToken(): string