Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DataSet::_construct() signature #37

Open
uphlewis opened this issue Feb 8, 2024 · 0 comments
Open

Update DataSet::_construct() signature #37

uphlewis opened this issue Feb 8, 2024 · 0 comments
Milestone
v5.0

Comments

@uphlewis
Copy link
Member

uphlewis commented Feb 8, 2024

#31

In the above issue we are supressing warnings.

  • Create a DataSet interface which defines public function __construct($values = [])
  • Update DataSet constructor to call $this->autoValidation(false)
  • Enumerate subclasses which override the constructor and check valid signatures and update to use calls to $this->autoValidation()
@uphlewis uphlewis added this to the v5.0 milestone Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.0
Development

No branches or pull requests
1 participant
@uphlewis