do not resolve not required elements

log stacktrace on panic on service start

Author: host6

godif.go

@@ -134,6 +134,9 @@ func ResolveAll() errs.Errors {
 	}
 
 	for target, provVar := range provided {
+		if !targetRequired(target) {
+			continue
+		}
 		if targetValue := reflect.ValueOf(target).Elem(); targetValue.IsNil() {
 			targetValue.Set(reflect.ValueOf(provVar[0].elem))
 		}
@@ -196,6 +199,15 @@ func ResolveAll() errs.Errors {
 	return nil
 }
 
+func targetRequired(target interface{}) bool {
+	for _, elem := range required {
+		if elem.elem == target {
+			return true
+		}
+	}
+	return false
+}
+
 func isSlice(kind reflect.Kind) bool {
 	return kind == reflect.Array || kind == reflect.Slice
 }

godif_test.go

@@ -292,7 +292,7 @@ func TestPackageUsedIfSomethigRequired(t *testing.T) {
 		t.Fatal()
 	}
 	assert.NotNil(t, injected1)
-	assert.NotNil(t, injected2)
+	assert.Nil(t, injected2) // not required
 }
 
 func TestPackageNotUsedIfNothingRequired(t *testing.T) {
@@ -323,6 +323,7 @@ func TestDataInject(t *testing.T) {
 	Reset()
 	var injected map[string]int
 	Provide(&injected, make(map[string]int))
+	Require(&injected)
 
 	errs := ResolveAll()
 	if errs != nil {
@@ -350,6 +351,9 @@ func TestProvideExtensionMapBasic(t *testing.T) {
 	Provide(&bucketDefsPtr, map[string]*bucketDef{})
 	Provide(&bucketDefs, map[string]bucketDef{})
 	Provide(&bucketDefsByKey, map[key]bucketDef{})
+	Require(&bucketDefsPtr)
+	Require(&bucketDefs)
+	Require(&bucketDefsByKey)
 
 	var bucketServicePtr = &bucketDef{Value: "val"}
 	var bucketService = bucketDef{Value: "val"}
@@ -586,6 +590,9 @@ func TestProvideExtensionSliceBasic(t *testing.T) {
 	Provide(&mySlice, make([]string, 0))
 	Provide(&bucketDefs, make([]bucketDef, 0))
 	Provide(&bucketDefsPtr, make([]*bucketDef, 0))
+	Require(&mySlice)
+	Require(&bucketDefs)
+	Require(&bucketDefsPtr)
 
 	var bucketServicePtr = &bucketDef{Value: "val"}
 	var bucketService = bucketDef{Value: "val"}

services/impl.go

@@ -14,6 +14,7 @@ import (
 	"os"
 	"os/signal"
 	"reflect"
+	"runtime/debug"
 
 	"github.com/untillpro/godif"
 )
@@ -85,7 +86,7 @@ func Start(startingCtx context.Context, servicesToStart []IService, verbose bool
 	defer func() {
 		if r := recover(); r != nil {
 			if verbose {
-				logln(fmt.Sprintf("Service paniced: %v: %v", reflect.TypeOf(startingService), r))
+				logln(fmt.Sprintf("Service paniced: %v: %v\n%s", reflect.TypeOf(startingService), r, string(debug.Stack())))
 			}
 			err = &EPanic{PanicData: r, PanicedService: startingService}
 		}