Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default ContentDialog button size does not match other buttons #18033

Open
Tracked by #19127
MartinZikmund opened this issue Aug 27, 2024 · 4 comments
Open
Tracked by #19127

Default ContentDialog button size does not match other buttons #18033

MartinZikmund opened this issue Aug 27, 2024 · 4 comments
Assignees
Labels
difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers kind/bug Something isn't working project/styling 👔 Categorizes an issue or PR as relevant to element styling

Comments

@MartinZikmund
Copy link
Member

Current behavior

Using Fluent styles, the button that is marked as default is noticeably smaller than the other buttons in the ContentDialog

ContentDialog dialog = new()
{
	Title = title,
	Content = text,
	PrimaryButtonText = Localizer.Instance.GetString("Yes"),
	SecondaryButtonText = Localizer.Instance.GetString("No"),
	DefaultButton = ContentDialogButton.Secondary,
	XamlRoot = _xamlRootProvider.XamlRoot
};

image

Tested on Skia, may be reproducible elsewhere too.

Expected behavior

Should be the same:

image

How to reproduce it (as minimally and precisely as possible)

See snippet above

Workaround

Use a custom style

Works on UWP/WinUI

Yes

Environment

No response

NuGet package version(s)

No response

Affected platforms

Skia (WPF), Skia (Linux X11), Skia (macOS), Skia (Linux Framebuffer), Skia (GTK)

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

@MartinZikmund MartinZikmund added kind/bug Something isn't working project/styling 👔 Categorizes an issue or PR as relevant to element styling difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers labels Aug 27, 2024
@morning4coffe-dev morning4coffe-dev self-assigned this Aug 27, 2024
@morning4coffe-dev
Copy link
Member

This issue is coming directly from AccentButtonStyle could be related to #6452 and could get fixed with #18103 as there is a workaround in the style. I will revisit once the issue is closed.

@MartinZikmund
Copy link
Member Author

@morning4coffe-dev The Fluent part of #18103 was done already, did things change?

@morning4coffe-dev
Copy link
Member

I see, I will test with the branch 👍

@MartinZikmund
Copy link
Member Author

Ping 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers kind/bug Something isn't working project/styling 👔 Categorizes an issue or PR as relevant to element styling
Projects
None yet
Development

No branches or pull requests

2 participants