Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleOrientationSensor shouldn't directly implement ISensorEventListener #12206

Closed
Youssef1313 opened this issue May 8, 2023 · 0 comments · Fixed by #12224
Closed

SimpleOrientationSensor shouldn't directly implement ISensorEventListener #12206

Youssef1313 opened this issue May 8, 2023 · 0 comments · Fixed by #12224
Assignees
@Youssef1313
Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request project/non-ui ⚙️ Categorizes an issue or PR as relevant to winrt (non-ui) triage/untriaged Indicates an issue requires triaging or verification

Comments

@Youssef1313
Copy link
Member

The interface should be implemented by a private nested class, just like all other sensors (e.g https://github.com/unoplatform/uno/blob/520bd48d8e8ef90568f8d12e996c458017e1571f/src/Uno.UWP/Devices/Sensors/Barometer.Android.cs#LL73C55-L73C75)

This will avoid having OnAccuracyChanged and OnSensorChanged being public.
@Youssef1313 Youssef1313 added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels May 8, 2023
@Youssef1313 Youssef1313 self-assigned this May 8, 2023
@Youssef1313 Youssef1313 mentioned this issue May 8, 2023
Open
@jeromelaban jeromelaban added the project/non-ui ⚙️ Categorizes an issue or PR as relevant to winrt (non-ui) label May 9, 2023
@Youssef1313 Youssef1313 linked a pull request May 9, 2023 that will close this issue
fix!: Avoid directly implementing ISensorEventListener on SimpleOrientationSensor on Android #12224
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Youssef1313 Youssef1313

Labels
difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request project/non-ui ⚙️ Categorizes an issue or PR as relevant to winrt (non-ui) triage/untriaged Indicates an issue requires triaging or verification
Projects
None yet
Milestone
No milestone
2 participants
@jeromelaban @Youssef1313