Add support for SocketCAN for Linux platforms #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SocketCAN support is dependent on merging unofficial-rev-port/CANBridge#5.
Forgot to add SocketCAN initialization. This is now resolved.
for the Ubuntu build |
The tests will fail regardless due to missing devices, however I wonder if this is related to there not being a device or a possible udev rule not being turned on for this. Regardless I don't think there is a specific thing we should be worried about with this symbol lookup error. |
|
On a Linux VM with a device connected, the following error occurs during The test will also hang. |
|
There has been an identified issue with CANBridge as a whole for test failures. This PR should not be merged until unofficial-rev-port/CANBridge#7 is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SocketCAN support is dependent on merging unofficial-rev-port/CANBridge#5.
Should resolve Linux-related #12.