Permission updates in the UI are slow

[chronark]

Preliminary Checks

• I have reviewed the documentation: https://unkey.dev/docs
• I have searched for existing issues: https://github.com/unkeyed/unkey/issues
• This issue is not a question, general help request, or anything other than a bug report directly related to Unkey. Please ask questions in our Discord community: https://unkey.dev/discord.

Reproduction / Replay Link (Optional)

No response

Issue Summary

We're looping through all required permissions and doing a network roundtrip for each.

unkey/apps/web/lib/trpc/routers/permission.ts

Line 123 in 6c516c3

async function upsertPermission(workspaceId: string, name: string): Promise<Permission> {

Steps to Reproduce

1. https://unkey.dev/app/settings/root-keys/new
2. add some permissions
3. save

Expected behavior

It should be much faster

Other information

No response

Screenshots

No response

Version info

irrelevant

[linear]

ENG-497 Permission updates in the UI are slow

[Praashh]

Hey, I have a doubt, created a new root key and I feel it's depend on the backend. is'nt it ?

[chronark]

can you elaborate?

[Praashh]

I tried to create a root key for test the speed, I feel UI updation slow because of backend response. correct me if I am wrong please.

[chronark]

yes it's the backend that is slow, I linked the code above

[Praashh]

So that means, we have to optimize the backend as well ?

[chronark]

the only bottleneck is in the backend, the ui just sends a trpc request

[Praashh]

Thanks for clearing. It takes some time understand the problem statement. Got it now, Can I work on that or someone from unkey is already working upon that?

[chronark]

sure, go ahead

[AkshayBandi027]

hey @chronark,
As mentioned above We're looping through all required permissions and doing a network roundtrip for each., I guess your talking about

we can make use of Promise.all() for concurrently doing a network request

Is this related as mentioned above or i am going in wrong direction ?

[chronark]

Yeah, I deliberately didn't do a promise.all, cause apparently that's an issue with planetscale

I haven't looked much deeper though and just accepted that it might be a bit slower for now.

I'm reworking permissions a little bit right now, and adding roles, potentially we don't even need to upsert in parallel anymore