Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Toast When Attempting to Set Unverified Email as Primary #2514

Open
3 tasks done
unrenamed opened this issue Oct 20, 2024 · 6 comments
Open
3 tasks done

Empty Toast When Attempting to Set Unverified Email as Primary #2514

unrenamed opened this issue Oct 20, 2024 · 6 comments
Assignees
Labels
Bug Something isn't working Needs Approval Needs approval from Unkey

Comments

@unrenamed
Copy link
Contributor

Preliminary Checks

Reproduction / Replay Link (Optional)

No response

Issue Summary

When a user tries to make an unverified email address their primary email, the application shows an empty toast notification, providing no feedback or error message.

Steps to Reproduce

  1. Log into your account.
  2. Navigate to the profile settings or account settings page.
  3. Add a new email address but do not verify it.
  4. Attempt to make the unverified email address your primary email.
  5. Observe the toast notification.

Expected behavior

When a user attempts to set an unverified email as their primary email:

  • The toast notification should display an informative message such as, "Please verify your email before making it primary."
  • The action should not be allowed, and the user should be instructed to verify their email first.

Or the button "Make Primary" should not be available in an unverified email dropdown at all.

Other information

No response

Screenshots

Screen.Recording.2024-10-20.at.15.06.14.mov

Version info

- OS:
- Node:
- npm:
@unrenamed unrenamed added Bug Something isn't working Needs Approval Needs approval from Unkey labels Oct 20, 2024
Copy link

linear bot commented Oct 20, 2024

@SandipGyawali
Copy link

SandipGyawali commented Oct 20, 2024

@unrenamed are you working on this issue ?
i'm thinking of collaborating to the project
after approval can i look at this issue it will be very helpful as well as thankful..

@unrenamed
Copy link
Contributor Author

unrenamed commented Oct 20, 2024

Let's wait for @chronark 's approval first. This issue may already be addressed as part of the auth/user account refactoring by the core team. See #2201 (comment)

@chronark
Copy link
Collaborator

yeah, auth related things are currently being worked on by @mcstepp
/award 50

Copy link

oss-gg bot commented Oct 20, 2024

Awarding unrenamed: 50 points 🕹️ Well done! Check out your new contribution on oss.gg/unrenamed

@GARY121github
Copy link
Contributor

@chronark Can I work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Needs Approval Needs approval from Unkey
Projects
None yet
Development

No branches or pull requests

5 participants