Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting recoverable: true when creating keys in the dashboard #2097

Open
3 tasks done
chronark opened this issue Sep 17, 2024 · 5 comments · May be fixed by #2110
Open
3 tasks done

Allow setting recoverable: true when creating keys in the dashboard #2097

chronark opened this issue Sep 17, 2024 · 5 comments · May be fixed by #2110
Labels
Feature New feature or request

Comments

@chronark
Copy link
Collaborator

Preliminary Checks

Is your feature request related to a problem? Please describe.

if you guys end up implementing the ability to create recoverable keys from dashboard that'd be awesome tho. rn we're iterating quickly and auth is evolving a lot so much faster to work with dashboard to generate test keys than have a million different server functions for generating keys.

also same thing for ownerId vs externalId. rn if I create a key in the dashboard it doesn't add an externalId and ownerId is marked as deprecated all over api docs. so if I try to query based on only externalId any dashboard created keys won't show up bc they're using ownerId

would be great to switch dashboard over to externalId if thats the way forward or at least provide the option to add/modify externalId so api and dashboard work seamlessly together.

Describe the solution

Add a toggle to mark a key as recoverable in the createKey UI
CleanShot 2024-09-17 at 09 14 44@2x

The trpc handler needs to be updated as well, the logic can be copied from

if (req.recoverable && api.keyAuth?.storeEncryptedKeys) {

Describe alternatives you have considered (if any)

No response

Additional context

No response

@chronark chronark added Feature New feature or request Needs Approval Needs approval from Unkey labels Sep 17, 2024
Copy link

linear bot commented Sep 17, 2024

@chronark
Copy link
Collaborator Author

petrykiw on discord requested this, let them know when it's shipped

@chronark chronark removed the Needs Approval Needs approval from Unkey label Sep 17, 2024
@harshsbhat
Copy link
Contributor

Is this a core-team? or can anyone work on this?

@chronark
Copy link
Collaborator Author

go for it

@harshsbhat
Copy link
Contributor

I think this issue will also require the logic to create and integrate an internal package named @unkey/vault. As we will need to this to encrypt keys when they are being created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
2 participants