Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: make breadcrumb + action look better #1990

Open
3 tasks done
guilhermerodz opened this issue Jul 29, 2024 · 8 comments
Open
3 tasks done

dashboard: make breadcrumb + action look better #1990

guilhermerodz opened this issue Jul 29, 2024 · 8 comments
Labels
Good first issue Good for newcomers Improvement Improve an existing feature

Comments

@guilhermerodz
Copy link
Contributor

Preliminary Checks

Reproduction / Replay Link (Optional)

No response

Issue Summary

Unkey is currently using breadcrumb in a row, and action in another row.

image

Steps to Reproduce

  1. Log into the platform
  2. Go to /apis and start navigating
  3. See the breadcrumbs and actions not looking good

Expected behavior

As a suggestion for better appearance; the right slot (empty) is a valid space for actions (could be a Next.js slot, too)

Other information

No response

Screenshots

No response

Version info

- OS:
- Node:
- npm:
@guilhermerodz guilhermerodz added Bug Something isn't working Needs Approval Needs approval from Unkey labels Jul 29, 2024
Copy link

linear bot commented Jul 29, 2024

@guilhermerodz guilhermerodz added Good first issue Good for newcomers Improvement Improve an existing feature and removed Bug Something isn't working Needs Approval Needs approval from Unkey labels Jul 29, 2024
@luanfonceca
Copy link

Hey @guilhermerodz,
I just wanted to let you know that I plan on taking this issue.

Here's my idea for the visuals for the breadcrumb with action:
Screenshot 2024-08-22 at 11 58 15 AM
Please let me know if that layout will work.

I've never used Slots in NextJS, but I can make that work.
I will get back to you with questions.

Also, I am unsure how much dedication I should give to the mobile view, as I need more context on mobile users' engagement on Unkey.

@chronark
Copy link
Collaborator

I'm not sure if we want to use a single bar or two

single:

[ bread/crumbs/...          action1, action2 ]

double:

[ bread/crumbs/...          generic actions ]
[ title                                page actions.   ]

As generic actions I'd classify stuff like "link to docs, feedback, notifications"
Whereas page actions are the ones you see right now: "copy id buttons and CRUD buttons"

wdyt @luanfonceca ?

@luanfonceca
Copy link

double:

[ bread/crumbs/...          generic actions ]
[ title                                page actions.   ]

As generic actions I'd classify stuff like "link to docs, feedback, notifications" Whereas page actions are the ones you see right now: "copy id buttons and CRUD buttons"

wdyt @luanfonceca ?

The Double layout works great!

This is where I'm at - working only in the /apis/... for now.
Screenshot 2024-08-25 at 8 26 03 AM

I will make sure to make this work with a 2x2 grid in the header;
And when I'm done with it, I will review the other pages

@chronark
Copy link
Collaborator

I thought some more, and we'll be introducing "environments" at some point
think of stripe's "test" vs "production" env if you're familiar with that and we need that to be prominently visible, so the top navbar would be perfect to display and toggle

[ bread/crumbs/...          🔔  | Docs | Feedback | Production 🔽  ]

This makes me think whether the 2nd bar should actually be done via parallel routes..
It contains page title + specific actions and would be pretty easy to do at the page or layout level, rather than in a separate directory

@luanfonceca
Copy link

@chronark do you think we can take this discussion to Discord?
I believe we can have a faster round-trip on messages to discuss this issue's objectives and overall scope.

@chronark
Copy link
Collaborator

absolutely, create a thread and link it here please

@harshsbhat
Copy link
Contributor

@luanfonceca are you still working on this issue? If not I would like to take on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers Improvement Improve an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants