Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypted metadata #1678

Open
3 tasks done
chronark opened this issue May 26, 2024 · 7 comments · May be fixed by #2059
Open
3 tasks done

Encrypted metadata #1678

chronark opened this issue May 26, 2024 · 7 comments · May be fixed by #2059
Labels
Feature New feature or request

Comments

@chronark
Copy link
Collaborator

Preliminary Checks

Is your feature request related to a problem? Please describe.

Currently meta data is not encrypted and stores as plain text in the db, which is not suitable to store PII or other secrets.

Describe the solution

I have 2 ideas for this:

  1. A flag to toggle encryption of the existing meta field
  2. A new encryptedMeta field that can be used alongside the original meta, similar to how clerk has private and public metadata

Describe alternatives you have considered (if any)

No response

Additional context

No response

@chronark chronark added the Feature New feature or request label May 26, 2024
Copy link

linear bot commented May 26, 2024

@mvares
Copy link

mvares commented May 30, 2024

@chronark, this could be divided into two parts: unsafe metadata and metadata

@chronark
Copy link
Collaborator Author

why "unsafe" over "encrypted"?

@mvares
Copy link

mvares commented May 30, 2024

why "unsafe" over "encrypted"?

Really, "encrypted" is better

@harshsbhat
Copy link
Contributor

@chronark So basically we need to add it in both the unkey SDK and the platform toggle button to encrypt it. Am I right?

@harshsbhat
Copy link
Contributor

So if I am right we need to add one more toggle button here saying "Encrypt Metadata". Also similar thing for the SDK

image

@chronark So basically we need to add it in both the unkey SDK and the platform toggle button to encrypt it. Am I right?

@chronark
Copy link
Collaborator Author

chronark commented Jul 6, 2024

I'd prefer a second card entirely

@harshsbhat harshsbhat linked a pull request Sep 2, 2024 that will close this issue
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants