Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove followRedirects from options since it does not support 🙏🏻 #57

Open
kricsleo opened this issue Jul 10, 2024 · 0 comments · May be fixed by #66
Open

Please remove followRedirects from options since it does not support 🙏🏻 #57

kricsleo opened this issue Jul 10, 2024 · 0 comments · May be fixed by #66
Labels
bug Something isn't working

Comments

@kricsleo
Copy link

Environment

nodejs: v20.12.0

Reproduction

Just look at the code is enough.

Describe the bug

node-http-proxy supports followRedirects, but this rewrite removed this feature.

This should be documented in the readme or with an accurate ProxyServerOptions, instead of just saying "Checkout http-party/node-http-proxy for more options and examples.".

I was misled by it and spent quite a time debugging it until I looked at the source code and saw this commented line 😢 .

// const agents = options.followRedirects ? followRedirects : nativeAgents;

Just remove this config from the ProxyServerOptions interface or document this would be less misleading 🙏🏻.

followRedirects?: boolean;

(Still thanks for the rewrite, and I'm willing to contribute ❤️ )

Additional context

No response

Logs

No response

@kricsleo kricsleo added the bug Something isn't working label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant