Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OSGi generation to bnd-maven-plugin #333

Open
keilw opened this issue Feb 20, 2021 · 1 comment
Open

Change OSGi generation to bnd-maven-plugin #333

keilw opened this issue Feb 20, 2021 · 1 comment
Labels

Comments

@keilw
Copy link
Member

keilw commented Feb 20, 2021

Change OSGi generation from Felix maven-bundle-plugin to bnd-maven-plugin.
The Felix plugin still seems problematic with extra attributes like Automatic-Module-Name after 4.x and that version of the plugin is not compatible with Java 15 or above, while the Bnd plugins work, see https://github.com/unitsofmeasurement/uom-systems.

@keilw keilw added the task label Feb 20, 2021
@keilw keilw added this to the 2.1.2 milestone Feb 20, 2021
@keilw keilw removed this from the 2.1.2 milestone Feb 21, 2021
@keilw
Copy link
Member Author

keilw commented Feb 21, 2021

Currently this fails with a Maven build error:

[ERROR] Failed to execute goal biz.aQute.bnd:bnd-maven-plugin:5.2.0:bnd-process (default) on project indriya: Classes found in the wrong directory: {META-INF/versions/14/tech/units/indriya/AbstractSystemOfUnits.class=tech.units.indriya.AbstractSystemOfUnits, META-INF/versions/12/tech/units/indriya/format/NumberDelimiterQuantityFormat.class=tech.units.indriya.format.NumberDelimiterQuantityFormat, META-INF/versions/12/tech/units/indriya/format/NumberFormatStyle.class=tech.units.indriya.format.NumberFormatStyle, META-INF/versions/14/module-info.class=module-info, META-INF/versions/14/tech/units/indriya/AbstractSystemOfUnits$1.class=tech.units.indriya.AbstractSystemOfUnits$1, META-INF/versions/12/tech/units/indriya/format/NumberDelimiterQuantityFormat$Builder.class=tech.units.indriya.format.NumberDelimiterQuantityFormat$Builder, META-INF/versions/9/tech/units/indriya/spi/UnitNameProvider.class=tech.units.indriya.spi.UnitNameProvider, META-INF/versions/12/tech/units/indriya/format/NumberDelimiterQuantityFormat$1.class=tech.units.indriya.format.NumberDelimiterQuantityFormat$1, META-INF/versions/9/module-info.class=module-info, META-INF/versions/14/tech/units/indriya/AbstractSystemOfUnits$Helper.class=tech.units.indriya.AbstractSystemOfUnits$Helper, META-INF/versions/9/tech/units/indriya/unit/UnitDimension.class=tech.units.indriya.unit.UnitDimension, META-INF/versions/12/module-info.class=module-info} -> [Help 1]
[ERROR] 

It may be possible to configure the BND plugin in a sophisticated way, but for now forget about Java 15 or 16 and keep building it with 14 until either a fix for the Felix plugin exists or we look into a more detailed way to configure BND.

keilw added a commit that referenced this issue Feb 21, 2021
@keilw keilw added the prio:3 Priority 3 label Jun 9, 2021
@keilw keilw added the deferred label Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant