fix(ghpr): Check for nil value

craciunoiuc · craciunoiuc · commit c9a37adc6e31 · 2024-01-27T11:10:47.000+02:00
Signed-off-by: Cezar Craciunoiu &lt;cezar.craciunoiu@gmail.com&gt;
diff --git a/internal/ghpr/ghpr_mergable.go b/internal/ghpr/ghpr_mergable.go
@@ -38,7 +38,7 @@ func (pr *PullRequest) SatisfiesMergeRequirements(ctx context.Context, opts ...P
 	}
 
 	pull, err := mopts.ghClient.GetPullRequest(ctx, pr.ghOrg, pr.ghRepo, pr.ghPrId)
-	if err != nil {
+	if err != nil || pull == nil {
 		return false, nil, fmt.Errorf("could not get pull request: %w", err)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ func (pr *PullRequest) SatisfiesMergeRequirements(ctx context.Context, opts ...P`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`pull, err := mopts.ghClient.GetPullRequest(ctx, pr.ghOrg, pr.ghRepo, pr.ghPrId)`
`41`		`- if err != nil {`
	`41`	`+ if err != nil \|\| pull == nil {`
`42`	`42`	`return false, nil, fmt.Errorf("could not get pull request: %w", err)`
`43`	`43`	`}`
`44`	`44`