From c82fe0a02d078c3597f88283ab871336567cc584 Mon Sep 17 00:00:00 2001 From: sven-oly Date: Fri, 29 Aug 2025 10:48:34 -0700 Subject: [PATCH 1/3] Change to elif --- verifier/check_known_issues.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/verifier/check_known_issues.py b/verifier/check_known_issues.py index 456dd037..8a126290 100644 --- a/verifier/check_known_issues.py +++ b/verifier/check_known_issues.py @@ -426,7 +426,7 @@ def compute_known_issues_for_single_test(test_type, test, platform_info): known_issue_found = False if test_type == ddt_data.testType.collation.value: known_issue_found = check_collation_issues(test, platform_info) - if test_type == ddt_data.testType.datetime_fmt.value: + elif test_type == ddt_data.testType.datetime_fmt.value: known_issue_found = check_datetime_known_issues(test, platform_info) elif test_type == ddt_data.testType.rdt_fmt.value: known_issue_found = check_rdt_known_issues(test, platform_info) From ba8969539a6268086083bca00b20828d389fca93 Mon Sep 17 00:00:00 2001 From: sven-oly Date: Wed, 8 Oct 2025 23:54:22 +0000 Subject: [PATCH 2/3] Fix code that supports ordering of platforms in summary dashboard --- verifier/summary_template.html | 2 +- verifier/testreport.py | 9 +++++++++ verifier/verifier.py | 1 - 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/verifier/summary_template.html b/verifier/summary_template.html index ee585314..d007ccf0 100644 --- a/verifier/summary_template.html +++ b/verifier/summary_template.html @@ -177,7 +177,7 @@ // If platform/exec order is specified, use that. let executed_platforms = []; // exec_set includes all those that are represented in the data - const platform_order = ["$platform_order"]; + const platform_order = $platform_order; if (platform_order.length <= 0 || platform_order[0] == 'alphabetic' || platform_order[0] == "None") { // Default is alphabetic sort diff --git a/verifier/testreport.py b/verifier/testreport.py index 0ab15f61..e29f081c 100644 --- a/verifier/testreport.py +++ b/verifier/testreport.py @@ -1165,6 +1165,10 @@ def __init__(self, file_base): self.templates = reportTemplate() + # Default + self.platform_order = \ + ['ICU4C', 'ICU4J', 'ICU4X', 'NodeJS', 'Dart_Web', 'Dart_Native'] + if self.debug > 1: logging.info('SUMMARY REPORT base = %s', self.file_base) @@ -1290,11 +1294,16 @@ def summarize_reports(self): def create_summary_html(self): # Generate HTML page containing this information # Create the template + + # Make a string that looks like a JS list. + order_of_platforms = '[' + "".join([f"\'{item}\', " for item in self.platform_order]) + ']' + html_map = { 'all_platforms': ', '.join(list(self.exec_summary.keys())), 'all_icu_versions': None, # TEMP!!! 'all_tests': ', '.join(list(self.type_summary.keys())), 'datetime': datetime.now().strftime('%Y-%m-%d %H:%M:%S'), + 'platform_order': order_of_platforms, } # Create header for each executor header_line = '' # TODO diff --git a/verifier/verifier.py b/verifier/verifier.py index 4c0c2b5c..646469e7 100644 --- a/verifier/verifier.py +++ b/verifier/verifier.py @@ -308,7 +308,6 @@ def create_summary_reports(self): summary_report = SummaryReport(self.file_base) summary_report.setup_all_test_results() - if self.options.platform_order: # Set the order of the platforms in the summary dashboard summary_report.platform_order = self.options.platform_order From 69ebbec1602bfdd73b7576df78e3ce10aa667d23 Mon Sep 17 00:00:00 2001 From: sven-oly Date: Fri, 10 Oct 2025 00:05:40 +0000 Subject: [PATCH 3/3] Fix some AI suggestions --- verifier/testreport.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/verifier/testreport.py b/verifier/testreport.py index e29f081c..4ea9c220 100644 --- a/verifier/testreport.py +++ b/verifier/testreport.py @@ -1166,8 +1166,7 @@ def __init__(self, file_base): self.templates = reportTemplate() # Default - self.platform_order = \ - ['ICU4C', 'ICU4J', 'ICU4X', 'NodeJS', 'Dart_Web', 'Dart_Native'] + self.platform_order = ['ICU4C', 'ICU4J', 'ICU4X', 'NodeJS', 'Dart_Web', 'Dart_Native'] if self.debug > 1: logging.info('SUMMARY REPORT base = %s', self.file_base) @@ -1296,7 +1295,7 @@ def create_summary_html(self): # Create the template # Make a string that looks like a JS list. - order_of_platforms = '[' + "".join([f"\'{item}\', " for item in self.platform_order]) + ']' + order_of_platforms = json.dumps(self.platform_order) html_map = { 'all_platforms': ', '.join(list(self.exec_summary.keys())),