Frontend update to reflect new Agency options without "All" #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelleln
commented
Nov 2, 2024
michelleln
commented
- when agency_selected is updated, the useEffect should override dataflow_selected to None
- when the page first loads, call the Jaden/Tomas funciton propogate_agency_options (name TBD) which shouldnt take in any paramters and returns a list of objects that represents the initial values for the agency dropdown options. Pass this into make_components to populate the agency dropdowns
…ow_selected to None when the page first loads, call the Jaden/Tomas funciton propogate_agency_options
meomancer
reviewed
Nov 7, 2024
| @@ -0,0 +1,33 @@ | |||
| # Generated by Django 3.2.16 on 2024-11-01 19:50 | |||
There was a problem hiding this comment.
Please delete this migrations @michelleln
meomancer
reviewed
Nov 7, 2024
| @@ -19,9 +19,8 @@ volumes: | |||
|
|
|||
There was a problem hiding this comment.
Please revert this @michelleln
I think it is because of autoformat from your side
meomancer
reviewed
Nov 7, 2024
| @@ -11,9 +11,9 @@ | |||
| # __date__ = '13/06/2023' | |||
| # __copyright__ = ('Copyright 2023, Unicef') | |||
|
|
|||
| FROM ubuntu:20.04 AS prod | |||
There was a problem hiding this comment.
Also please don't include this to commit
I will update Dockerfile to split between arm and non arm
|
Hi @michelleln |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.