Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why !isnothing(basisfunction) here? #112

Open
behinger opened this issue Apr 26, 2023 · 1 comment
Open

why !isnothing(basisfunction) here? #112

behinger opened this issue Apr 26, 2023 · 1 comment

Comments

@behinger
Copy link
Member

I dont get why one checks for !isnothing(basisfunction) => a basisfunction exists, but at the same time type <: UnfoldLinearMixedModel
=> this case shouldnt even exist - a UnfoldLinearMixedModel never has a basisfunction, and a UnfoldLinearMixedModelContinuousTime always has one. So whcih is it?

if (!isnothing(basisfunction)) & (type <: UnfoldLinearMixedModel)

@behinger
Copy link
Member Author

a) the following line of code is never reached and can be removed
b) UnfoldLinearMixedModelContinuousTime doesnt currently work (but there are tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant