From bf022c9400c0c2553ae80ed338dc1b69624cd0b6 Mon Sep 17 00:00:00 2001
From: Matheus Moraes <matheusfaria.moraes@gmail.com>
Date: Mon, 18 Mar 2024 17:10:57 -0300
Subject: [PATCH] fix: handle compile errors (#40)

* fix: handle compile errors

* add license header in compiler_test.go
---
 pkg/validator/compiler.go      |   6 ++
 pkg/validator/compiler_test.go | 113 +++++++++++++++++++++++++++++++++
 2 files changed, 119 insertions(+)
 create mode 100644 pkg/validator/compiler_test.go

diff --git a/pkg/validator/compiler.go b/pkg/validator/compiler.go
index b9b0e1d..49fafc4 100644
--- a/pkg/validator/compiler.go
+++ b/pkg/validator/compiler.go
@@ -70,8 +70,14 @@ func Compile(check types.Check, apiResources []*metav1.APIResourceList, kubeVers
 	}
 
 	variables, err := compileVariables(env, check.Variables)
+	if err != nil {
+		return nil, err
+	}
 
 	prgs, err := compileValidations(env, check.Validations)
+	if err != nil {
+		return nil, err
+	}
 
 	apiVersions := make([]string, 0, len(apiResources))
 	for _, resource := range apiResources {
diff --git a/pkg/validator/compiler_test.go b/pkg/validator/compiler_test.go
new file mode 100644
index 0000000..d607642
--- /dev/null
+++ b/pkg/validator/compiler_test.go
@@ -0,0 +1,113 @@
+// Copyright 2024 Undistro Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package validator
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/undistro/marvin/pkg/types"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/version"
+)
+
+func TestCompile(t *testing.T) {
+	var apiResources []*metav1.APIResourceList
+	kubeVersion := &version.Info{Major: "1", Minor: "29", GitVersion: "v1.29.2"}
+	podsMatch := types.Match{Resources: []types.ResourceRule{{
+		Group:    "",
+		Version:  "v1",
+		Resource: "pods",
+	}}}
+
+	tests := []struct {
+		check   types.Check
+		wantErr assert.ErrorAssertionFunc
+	}{
+		{
+			check: types.Check{
+				ID:    "ok",
+				Match: podsMatch,
+				Validations: []types.Validation{{
+					Expression: `variables.isWindows || allContainers.size() > 0`,
+				}},
+				Variables: []types.Variable{{
+					Name:       "isWindows",
+					Expression: `podSpec.?os.?name.orValue("") == "windows"`,
+				}},
+			},
+			wantErr: assert.NoError,
+		},
+		{
+			check: types.Check{
+				ID:    "validation error",
+				Match: podsMatch,
+				Validations: []types.Validation{{
+					Expression: `allContainers.sizeX() > 0`,
+				}},
+			},
+			wantErr: assert.Error,
+		},
+		{
+			check: types.Check{
+				ID:    "variable error",
+				Match: podsMatch,
+				Validations: []types.Validation{{
+					Expression: `variables.isWindows || allContainers.size() > 0`,
+				}},
+				Variables: []types.Variable{{
+					Name:       "isWindows",
+					Expression: `foo`,
+				}},
+			},
+			wantErr: assert.Error,
+		},
+		{
+			check: types.Check{
+				ID: "no workload",
+				Match: types.Match{Resources: []types.ResourceRule{{
+					Group:    "",
+					Version:  "v1",
+					Resource: "configmaps",
+				}}},
+				Validations: []types.Validation{{
+					Expression: `allContainers.size() > 0`,
+				}},
+			},
+			wantErr: assert.Error,
+		},
+		{
+			check: types.Check{
+				ID:          "no validations",
+				Match:       podsMatch,
+				Validations: nil,
+				Variables: []types.Variable{{
+					Name:       "isWindows",
+					Expression: `podSpec.?os.?name.orValue("") == "windows"`,
+				}},
+			},
+			wantErr: assert.Error,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.check.ID, func(t *testing.T) {
+			_, err := Compile(tt.check, apiResources, kubeVersion)
+			if !tt.wantErr(t, err, fmt.Sprintf("Compile(%v, %v, %v)", tt.check, apiResources, kubeVersion)) {
+				return
+			}
+		})
+	}
+}