Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - syntaxWarning in constitutive models #203

Closed
bknight1 opened this issue Jun 10, 2024 · 3 comments
Closed

[BUG] - syntaxWarning in constitutive models #203

bknight1 opened this issue Jun 10, 2024 · 3 comments

Comments

@bknight1
Copy link
Member

Describe the bug

  • What is the bug?
../underworld3/src/underworld3/constitutive_models.py:634: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if inner_self.yield_stress_min.value is not 0:
  • What version code?
    latest dev branch, python-3.10.14
  • What system are you running the code on?
    M2 - arm
  • Steps to reproduce?
    Fresh install of updated dev branch

Screenshots

@bknight1 bknight1 changed the title [BUG] - syntaxWarning - [BUG] - syntaxWarning in constitutive models Jun 10, 2024
@bknight1
Copy link
Member Author

Few 'is not' statements in the file, not sure if we want to update them all

@julesghub
Copy link
Member

Yeah I say we update them.
!= is a test about equality of value.
is not is a test about the identify of the python object.

@bknight1
Copy link
Member Author

bknight1 commented Aug 8, 2024

Fixed in #222

@bknight1 bknight1 closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants