Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor away the need for ignore-errors #49

Open
CyberShadow opened this issue Nov 22, 2019 · 1 comment
Open

Refactor away the need for ignore-errors #49

CyberShadow opened this issue Nov 22, 2019 · 1 comment
Labels
enhancement

Comments

@CyberShadow
Copy link
Member

Ignoring all errors may hide important information from users / developers.

#45 fixes one instance of this (though, with-demoted-errors is not a complete fix).

As for the other remaining instance, the code seems to currently rely on it (i.e. errors occur as part of normal functioning). The code should be updated to handle error conditions explicitly in the place where they may occur; then, ignore-errors can be removed.
CyberShadow added a commit to CyberShadow/undercover.el that referenced this issue Jan 19, 2021
@CyberShadow
Improve curl invocation when uploading to coveralls.io
b82fa83 
- Use call-process instead of relying on a shell to perform argument
  splitting

  This will also fix running undercover in paths with spaces or
  shell special characters.

- Don't use shut-up

  All uses of this package should eventually be removed.

  Also see issue undercover-el#49.

- Show curl output

  It includes useful output, namely the Coveralls job ID and an URL to
  the coverage report page.

- Actually fail if the upload fails

  The old code would report that everything is OK even on a connection
  or server error.
@CyberShadow
Copy link
Member Author

shut-up is another thing that we could probably use less of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CyberShadow