Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-gyp installation issue #16

Open
whizkid79 opened this issue Oct 5, 2016 · 17 comments
Open

node-gyp installation issue #16

whizkid79 opened this issue Oct 5, 2016 · 17 comments
Labels

Comments

@whizkid79
Copy link

I tried to get node-jack-connector installed on with node v6.7.0.
Unfortunately it throws a lot of errors on node-gyp. Any advices?

This is the lengthy output:
https://gist.github.com/whizkid79/a006ee88b97228fc87eb0439bd422ea3

@unclechu
Copy link
Owner

unclechu commented Oct 6, 2016

@whizkid79 I didn't try to build this for years. My guess is it's because of broken backward compatibility of V8 API, some guy advised me to use this abstraction to keep it works, but I didn't touch this project for a long time, may be I'll fix this, but don't know how soon.

@unclechu unclechu added the bug label Oct 6, 2016
@whizkid79
Copy link
Author

thanks @unclechu. That's the same results i found out during my research yesterday e.g. see:
https://nodesource.com/blog/c-add-ons-for-nodejs-v4/

I think I give it a try to migrate it to the new api. Are you interested in a PR?

@unclechu
Copy link
Owner

unclechu commented Oct 6, 2016

@whizkid79 Only if it works with older version too (actually with 0.9.0). I'm not interested in fix for new version and brake backward compatibility for old one.

@whizkid79
Copy link
Author

I can understand that, @unclechu. I'm struggeling to get it installed. Can you please give me your versions of node, npm and node-gyp?
These would be a great addition to the readme...

Mine are:

node -v
v0.9.12

npm -v
3.10.8

node-gyp -v
v3.4.0

@unclechu
Copy link
Owner

unclechu commented Oct 6, 2016

@whizkid79 It was long time ago, I don't have this anymore, but we can see here:

"node": ">=0.9.0"
and use version 0.9.0 with npm version that comes with this version that in turn can be get there: https://nodejs.org/download/release/v0.9.0/

@unclechu
Copy link
Owner

unclechu commented Oct 6, 2016

It also becomes complicated because now we need to test it on couple of major versions, at least on these:

  • 0.9.0
  • 0.10.0
  • 0.11.0
  • 0.12.0
  • 1.0.0 (io.js)
  • 2.0.0 (io.js)
  • 3.0.0 (io.js)
  • 4.0.0
  • 5.0.0
  • 6.0.0

@whizkid79
Copy link
Author

I'm not sure if it would change the situation a lot, because it seams kind of impossible to get it running. I've tried 0.9.0, 0.9.12 (latest), 0.10.x (latest), and it fails on all places. Looks like it is not usable at all...
Do you have a system somewhere to find a working combination of versions?
I could get past the node api issues, but then it was complaining about uv_worker_... something

@whizkid79
Copy link
Author

a version working with recent node versions (maybe in a separate branch) would be benefitial I guess. but it would be a lot of manuall work to move it to the latest api.

@kenjinp
Copy link

kenjinp commented Oct 8, 2016

👍

@unclechu
Copy link
Owner

unclechu commented Oct 8, 2016

I guess it's better to release new major version based on nan API abstraction than trying to add some pre-processor conditions for different versions. Now I'm busy, may be after I finish my current tasks I'll try to do it.

@matansag
Copy link

Hi @unclechu any progress with that?
I'm trying to use it with node 8
10x!

@unclechu
Copy link
Owner

@matansag sorry but no, I'm not enthusiastic enough to spend time writing js code anymore. Not sure if I'm going back to work on this project. Maybe if I would have more free time.

@M-Abozaid
Copy link

@matansag do you plan to work on this, and is there an alternative?

@stratemeyerjw
Copy link

same here, its looking grim to be able to use jack audio with node.

@omarcostahamido
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants
@unclechu @stratemeyerjw @kenjinp @whizkid79 @omarcostahamido @M-Abozaid @matansag and others