Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a question about fkl code? #52

Open
willmao2013 opened this issue Jan 22, 2019 · 1 comment
Open

a question about fkl code? #52

willmao2013 opened this issue Jan 22, 2019 · 1 comment
Labels

Comments

@willmao2013
Copy link

willmao2013 commented Jan 22, 2019

Hi Julieta,

Thank you for releasing your code.

I am a little bit confused about these code in fkl.

xangle = angles[ rotInd[i][0]-1 ]
yangle = angles[ rotInd[i][1]-1 ]
zangle = angles[ rotInd[i][2]-1 ]

thisPosition = np.array([xangle, yangle, zangle])

In angles variable, there should only be expmap of rotation matrix for each joint except for the first three elements. Why these code use some of the elements as the positions of the joints?

Thank you
Wei

@una-dinosauria
Copy link
Owner

Hi! Please see #26 (comment)

I believe this is a mistake I made. If you fix it please consider submitting a PR request.

Note that this code is used for visualization only, so it does not affect training/validation.

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants