Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-rename-default #119

Closed
AndreaPontrandolfo opened this issue Jul 29, 2024 · 3 comments · Fixed by #132
Closed

no-rename-default #119

AndreaPontrandolfo opened this issue Jul 29, 2024 · 3 comments · Fixed by #132
Labels
good first issue Good for newcomers PR welcome

Comments

@AndreaPontrandolfo
Copy link

Any chance of porting no-rename-default from upstream?

The PR is there but it never got merged (eslint-plugin-import is basically abandonware at this point).
@SukkaW
Copy link
Collaborator

SukkaW commented Aug 2, 2024

I have been very busy recently. I'm not a full-time open-source contributor and my schedule is packed. But if you want to submit a PR on this, I am more than happy to review it.

@SukkaW SukkaW added PR welcome good first issue Good for newcomers labels Aug 2, 2024
@silverwind
Copy link

It does seem like a useful rule to me.

@SukkaW SukkaW mentioned this issue Aug 26, 2024
Merged
@SukkaW
Copy link
Collaborator

SukkaW commented Aug 26, 2024 •
edited
Loading

@silverwind @AndreaPontrandolfo I've backported the PR to eslint-plugin-import-x in #132. I decided to include this rule in the upcoming 4.1.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers PR welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: no-rename-default SukkaW/eslint-plugin-import-x
3 participants
@silverwind @AndreaPontrandolfo @SukkaW