Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence Run Manager: replace 'instrument_run_id' with 'id' for unique identifier #884

Closed
raylrui opened this issue Feb 28, 2025 · 1 comment
Assignees
Labels
bug Something isn't working migration Related to data migration

Comments

@raylrui
Copy link
Contributor

raylrui commented Feb 28, 2025

When we re-trigger a sequence run in Sequence Hub (Base Space) with same sequencing data (RunInfo.xml ), it may has same instrumentRunId (instrumentRunId is set by the RunInfo.xml).
This may cause combination of different runs, and as the run id and apiUrl is not updated, the run details and sample sheet api call will be failed.

See example in dev: https://orcaui.dev.umccr.org/runs/sequence/seq.01JN2WW3887X8BH3P6NMPWVPRD
events compared:
Image

So rather than using instrumentRunId as the unique identifier, run 'id' should be a better choice. And in early stage of bssh events when run files are still uploading, there is no instrumentRunId set.

Image

@raylrui raylrui added bug Something isn't working migration Related to data migration labels Feb 28, 2025
@raylrui raylrui self-assigned this Feb 28, 2025
@raylrui
Copy link
Contributor Author

raylrui commented Mar 25, 2025

This is now has been resolved as #885

@raylrui raylrui closed this as completed Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working migration Related to data migration
Projects
None yet
Development

No branches or pull requests

1 participant