Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filemanager: add crawl function #852

Closed
mmalenic opened this issue Feb 4, 2025 · 4 comments · Fixed by #859
Closed

filemanager: add crawl function #852

mmalenic opened this issue Feb 4, 2025 · 4 comments · Fixed by #859
Assignees
Labels
feature New feature filemanager an issue relating to the filemanager

Comments

@mmalenic
Copy link
Member

mmalenic commented Feb 4, 2025

I think the filemanager API should have a crawl function. This could be based on the existing inventory function, but I think it might be more convenient to just use list operations directly. Often records become out of date due to missing features or bugs, so along with ingesting new objects, the crawl function could be used to correct records if they are inconsistent. By placing this inside the filemanager directly, S3 API code can be re-used, rather than tying the logic to update scripts and individual API calls.

Related to #844.

@mmalenic mmalenic self-assigned this Feb 4, 2025
@mmalenic mmalenic added feature New feature filemanager an issue relating to the filemanager labels Feb 4, 2025
@alexiswl
Copy link
Member

alexiswl commented Feb 5, 2025

@mmalenic could this be a workaround in the interim? https://stackoverflow.com/a/37475908/6946787

@mmalenic
Copy link
Member Author

mmalenic commented Feb 5, 2025

Possibly.. All the filemanager needs to link the objects is the umccr-org:OrcaBusFileManagerIngestId tag which is present on objects, which should have the value of the ingest_id. So if copying from source to destination also copies the tags and that triggers a new Object Created event, then the filemanager should pick up the existing tag.

@mmalenic
Copy link
Member Author

mmalenic commented Feb 5, 2025

Sorry to clarify, the tag with the ingest id is already present, so I think this should work if it creates a new Object Created event.

@alexiswl
Copy link
Member

alexiswl commented Feb 5, 2025

No stress, for these runs we're compressing them so they will generate new objects anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature filemanager an issue relating to the filemanager
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants