Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Loss in RichText Fields After Upgrading to Umbraco 15.2.0 #18275

Open
martinthogersen opened this issue Feb 10, 2025 · 10 comments
Open
Assignees
Labels

Comments

@martinthogersen
Copy link

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.2.0

Bug summary

When upgrading an Umbraco website from version 13.6.0 to 15.2.0, some content is lost.

The issue affects RichText Data Types nested within BlockList Data Types.

In the image below, the left side shows Umbraco 13.6.0, while the right side displays 15.2.0, highlighting the missing content.

During the upgrade, the following error appears in the console:

System.Text.Json.JsonException: JSON deserialization for type 'Umbraco.Cms.Core.RichTextEditorValue' was missing required properties including: 'blocks'.
   at System.Text.Json.ThrowHelper.ThrowJsonException_JsonRequiredPropertyMissing(JsonTypeInfo parent, BitArray requiredPropertiesSet)
   at System.Text.Json.Serialization.Converters.ObjectDefaultConverter`1.OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
   at System.Text.Json.Serialization.JsonConverter`1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value, Boolean& isPopulatedValue)
   at System.Text.Json.Serialization.JsonConverter`1.ReadCore(Utf8JsonReader& reader, T& value, JsonSerializerOptions options, ReadStack& state)
   at System.Text.Json.JsonSerializer.ReadFromSpan[TValue](ReadOnlySpan`1 json, JsonTypeInfo`1 jsonTypeInfo)
   at Umbraco.Cms.Infrastructure.Serialization.SystemTextJsonSerializerBase.Deserialize[T](String input)
   at Umbraco.Cms.Core.PropertyEditors.RichTextPropertyEditorHelper.TryParseRichTextEditorValue(Object value, IJsonSerializer jsonSerializer, ILogger logger, RichTextEditorValue& richTextEditorValue)

_

Image

Specifics

No response

Steps to reproduce

See above.

Expected result / actual result

No response

Copy link

Hi there @martinthogersen!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@Zeegaan
Copy link
Member

Zeegaan commented Feb 10, 2025

Hello, this is sadly a regression, we are aware and are looking to fix it ASAP 🕵
Look out for a patch coming hopefully tomorrow 😁

I wIll go ahead and close this, as it is already reported here #18252

Thanks for reporting though! 🐛

@Zeegaan Zeegaan closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2025
@martinthogersen
Copy link
Author

@Zeegaan Thank you. Where can I follow the updates? You're linking to this issue 😅

@Zeegaan
Copy link
Member

Zeegaan commented Feb 11, 2025

Sorry about that... Fixed the link in the comment now 🙈

@martinthogersen
Copy link
Author

@Zeegaan This issue is still present in version 15.2.1. Unfortunately, content is still lost during migration, and the same error described above occurs.

I believe this is a critical bug that needs to be investigated and resolved. I've encountered it on two Umbraco websites we are in the process of upgrading.

@Zeegaan
Copy link
Member

Zeegaan commented Feb 12, 2025

@martinthogersen Feel free to re-open this, if you can still reproduce in 15.2.1 🚀

@martinthogersen
Copy link
Author

@Zeegaan I don't have permission to reopen:

Image

@Zeegaan Zeegaan reopened this Feb 12, 2025
@Zeegaan Zeegaan assigned Zeegaan and Migaroez and unassigned Zeegaan Feb 12, 2025
@Migaroez
Copy link
Contributor

Having a look at this. If you have a small example database I can get started with, please send it my way.

@martinthogersen
Copy link
Author

@Migaroez Please share info about where to send the database copy to you.

@Migaroez
Copy link
Contributor

Same as last time ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants