Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umbraco 14 - Block Grid Area size does not save #16640

Open
deanleigh opened this issue Jun 20, 2024 · 9 comments
Open

Umbraco 14 - Block Grid Area size does not save #16640

deanleigh opened this issue Jun 20, 2024 · 9 comments

Comments

@deanleigh
Copy link

deanleigh commented Jun 20, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14

Bug summary

Block Grid Area sizes are lost on save

Specifics

No response

Steps to reproduce

Create a block grid
Create a layout
Resize an area in that layout
Save it
the size is lost

Expected result / actual result

Sizes of areas would stay as saved


This item has been added to our backlog AB#41872

Copy link

Hi there @deanleigh!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@JoJk0
Copy link

JoJk0 commented Jun 21, 2024

Duplicate of #16372 ?

@deanleigh
Copy link
Author

I think it is the same but I am seeing the columns at 6 columns by default.
So even changing a single column from 6 to 12 and save it goes back to 6.

@elit0451
Copy link
Member

Hi both 👋 thanks for reaching out!

We are already working on the column issue with the block grid, so I will close this as duplicate 🙂

@iOvergaard
Copy link
Contributor

Hi everyone, this issue is related to the configuration of the area sizes in the block grid configuration, whereas #16372 concerns saving content blocks with varying sizes. I would reopen this issue to address both problems, even though they might be overlapping.

@nielslyngsoe
Copy link
Member

Hi @deanleigh

Thanks for reporting this, I have checked your case with latest code base, thats v.14.1. and here it is working.

Just to be sure my approach that is working is the following:

  • Create a Document Type,
  • Append a Property with a DataType of Block Grid Editor with two Block Types.
  • Block Type A, is allowed in the root and has two areas.
  • Block Type B, is allowed in areas and is configured for 4 different column spans, 3,6,9,12.
  • Create a Document of that type
  • Create Block Type A
  • Create two Block Type Bs inside Block Type A.
  • Resize the Blocks so they become ColumnSpan 3 and thereby fits next to eachother.
  • Save it
  • And verify that document was saved.

@deanleigh
Copy link
Author

Hey @nielslyngsoe that sounds like the same steps so great news if that is fixed

@huwred
Copy link

huwred commented Jun 27, 2024

I'm not sure this is fixed, or a different issue. but if you just add a block element and give it allow in root and two areas of say size 8 and 4, then save. The block element just defaults back to 2 6 column areas

@iOvergaard
Copy link
Contributor

Thanks, @huwred, I will re-open this to investigate.

@iOvergaard iOvergaard reopened this Jun 27, 2024
@iOvergaard iOvergaard added the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Jun 27, 2024
@iOvergaard iOvergaard removed the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants