Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popups are not displayed at URLs provided by permalink #1970

Open
rikutaromanabe opened this issue Jul 5, 2024 · 13 comments
Open

Popups are not displayed at URLs provided by permalink #1970

rikutaromanabe opened this issue Jul 5, 2024 · 13 comments
Labels

Comments

@rikutaromanabe
Copy link

Describe the bug
Popups are not displayed at URLs provided by permalinks.
When a URL provided by permalink is opened in a different browser, the popup may or may not be displayed.

To Reproduce

  1. click on any permalink and copy the URL provided
  2. open the copied URL in another browser
  3. no pop-up appears

Expected behavior
The popup should appear.

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome, Safari, Firefox
@yohanboniface
Copy link
Member

Can you please share an URL as asked in the issue template ?

@yohanboniface
Copy link
Member

I cannot reproduce, I see the popup when I:

  • click on your link above
  • copy the link on another tab
  • copy the link in another browser

Maybe it's on a specific browser / version ? Or can you try to be more specific on process you use to reproduce the bug ?

I'm curious if anyone else can reproduce, so we may find the common denominator (cc @davidbgk if you can try on your side)

@rikutaromanabe
Copy link
Author

Thanks for the verification.
The permalinks on this site rarely pop up in my environment.
Please try it.
https://umap.openstreetmap.fr/ja/map/map_672698?feature=20025#16/35.7034/139.8189
https://umap.openstreetmap.fr/ja/map/map_672698?feature=3036#17/35.7054/139.8080

@davidbgk
Copy link
Contributor

davidbgk commented Jul 5, 2024

I confirm that it works for me too.

@rikutaromanabe
Copy link
Author

Thanks.
Does the permalink on map_672698 work ?

@rikutaromanabe
Copy link
Author

In my environment, the position and zoom are displayed correctly but do not pop up.
Is this an environment-dependent problem?
OMG

@davidbgk
Copy link
Contributor

davidbgk commented Jul 5, 2024

This is probably a race condition given the amount of data, we're investigating ATM.

@yohanboniface
Copy link
Member

There is certainly a race condition somewhere, but as stated by David, the amount of data/layers does not help.

Do you need that much layers shown at load ? You may display only some of those and users display the other when they need ?

@rikutaromanabe
Copy link
Author

I see.
So the large amount of data has increased the burden on the umap server.
The concept of this map is to enjoy the city entertainment by combining mass layers and mass data, but if there is a system burden, then we should reconsidered the method.

@davidbgk
Copy link
Contributor

davidbgk commented Jul 5, 2024

Capture d’écran, le 2024-07-05 à 13 26 04

This is definitely a lot for each and every users' browser to handle.

@rikutaromanabe
Copy link
Author

I should consider ways to thin out the display according to scale.

@rikutaromanabe
Copy link
Author

I have found that this is not a bug.
We are very grateful for your consideration.
I am glad we had a useful discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants