Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker container crashed with version 2.4.x #1947

Open
geimist opened this issue Jun 27, 2024 · 7 comments
Open

Docker container crashed with version 2.4.x #1947

geimist opened this issue Jun 27, 2024 · 7 comments
Labels

Comments

@geimist
Copy link
Contributor

geimist commented Jun 27, 2024

Describe the bug
If I use the Docker image >= 2.4, the container does not start successfully. With the 2.3.1 image, the container starts as usual.

Have I overlooked a necessary adjustment?

container log (Lines in the log are sorted from new to old)
> RuntimeError: Max post-process passes exceeded.
> raise processed
> File \"/venv/lib/python3.11/site-packages/umap/storage.py\", line 46, in post_process
> for original_path, processed_path, processed in processor:
> File \"/venv/lib/python3.11/site-packages/django/contrib/staticfiles/management/commands/collectstatic.py\", line 148, in collect
> ^^^^^^^^^^^^^^
> collected = self.collect()
> File \"/venv/lib/python3.11/site-packages/django/contrib/staticfiles/management/commands/collectstatic.py\", line 209, in handle
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> output = self.handle(*args, **options)
> File \"/venv/lib/python3.11/site-packages/django/core/management/base.py\", line 459, in execute
> self.execute(*args, **cmd_options)
> File \"/venv/lib/python3.11/site-packages/django/core/management/base.py\", line 413, in run_from_argv
> self.fetch_command(subcommand).run_from_argv(self.argv)
> File \"/venv/lib/python3.11/site-packages/django/core/management/__init__.py\", line 436, in execute
> utility.execute()
> File \"/venv/lib/python3.11/site-packages/django/core/management/__init__.py\", line 442, in execute_from_command_line
> management.execute_from_command_line()
> File \"/venv/lib/python3.11/site-packages/umap/bin/__init__.py\", line 9, in main
> ^^^^^^
> sys.exit(main())
> File \"/venv/bin/umap\", line 8, in <module>
> Traceback (most recent call last):
> Error with file All
> Loaded local config from /etc/umap/umap.conf    

Additional context
Installed at Synology DSM 7.2 (Container Manager)

@geimist geimist added the bug label Jun 27, 2024
@RichardHausgartner
Copy link

I just want to conform @geimist bug issue.
I run 2.3.1 and the docker update fails to:
-> 2.4.0
-> 2.4.2

(2.4.1 untested, but it seems the same problem)

@yohanboniface
Copy link
Member

I'm not exactly sure why this happens, as we deployed with Docker on our ANCT instance without issue, and I can run it locally with docker compose, but the error message seems the same as the one we hit recently, and fixed in master:

891f046

We'll deploy a new version including this fix this week, let's see if it fixes your issue to!

@geimist
Copy link
Contributor Author

geimist commented Jul 15, 2024

Unfortunately, the problem still exists with version 2.5.1: 🙁

2024/07/15 14:42:15,stdout,Loaded local config from /etc/umap/umap.conf
2024/07/15 14:42:27,stdout,Error with file All
2024/07/15 14:42:27,stderr,Traceback (most recent call last):
2024/07/15 14:42:27,stderr,"  File \"/venv/bin/umap\", line 8, in <module>
2024/07/15 14:42:27,stderr,    sys.exit(main())
2024/07/15 14:42:27,stderr,             ^^^^^^
2024/07/15 14:42:27,stderr,"  File \"/venv/lib/python3.11/site-packages/umap/bin/__init__.py\", line 9, in main
2024/07/15 14:42:27,stderr,    management.execute_from_command_line()
2024/07/15 14:42:27,stderr,"  File \"/venv/lib/python3.11/site-packages/django/core/management/__init__.py\", line 442, in execute_from_command_line
2024/07/15 14:42:27,stderr,    utility.execute()
2024/07/15 14:42:27,stderr,"  File \"/venv/lib/python3.11/site-packages/django/core/management/__init__.py\", line 436, in execute
2024/07/15 14:42:27,stderr,    self.fetch_command(subcommand).run_from_argv(self.argv)
2024/07/15 14:42:27,stderr,"  File \"/venv/lib/python3.11/site-packages/django/core/management/base.py\", line 413, in run_from_argv
2024/07/15 14:42:27,stderr,"    self.execute(*args, **cmd_options)
2024/07/15 14:42:27,stderr,"  File \"/venv/lib/python3.11/site-packages/django/core/management/base.py\", line 459, in execute
2024/07/15 14:42:27,stderr,"    output = self.handle(*args, **options)
2024/07/15 14:42:27,stderr,             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024/07/15 14:42:27,stderr,"  File \"/venv/lib/python3.11/site-packages/django/contrib/staticfiles/management/commands/collectstatic.py\", line 209, in handle
2024/07/15 14:42:27,stderr,    collected = self.collect()
2024/07/15 14:42:27,stderr,                ^^^^^^^^^^^^^^
2024/07/15 14:42:27,stderr,"  File \"/venv/lib/python3.11/site-packages/django/contrib/staticfiles/management/commands/collectstatic.py\", line 148, in collect
2024/07/15 14:42:27,stderr,"    for original_path, processed_path, processed in processor:
2024/07/15 14:42:27,stderr,"  File \"/venv/lib/python3.11/site-packages/umap/storage.py\", line 50, in post_process
2024/07/15 14:42:27,stderr,    raise processed
2024/07/15 14:42:27,stderr,RuntimeError: Max post-process passes exceeded.
date,stream,content
umap-app-1

@davidbgk
Copy link
Contributor

@geimist 😞

It appears that you're hitting this limit which raises that issue.

Do you have a way to bump that limit here within your container prior to (re)run the collectstatic command? Let's say max_post_process_passes = 50 to see if it fixes the deployment and then we'll refine the value.

@geimist
Copy link
Contributor Author

geimist commented Jul 15, 2024

I think I need support for this.
Since the container cannot be started, I would probably have to adapt the image.
Or can I adjust this in the configuration or as an environment parameter?

@davidbgk
Copy link
Contributor

Indeed that's not trivial and I probably have to release a dedicated image to test.

By the way, do you have/set custom statics for your instance?

@geimist
Copy link
Contributor Author

geimist commented Jul 15, 2024

By the way, do you have/set custom statics for your instance?

No, not to my knowledge.
In the django-settings.py it says:
STATICFILES_DIRS = [] # May be extended when using UMAP_CUSTOM_STATICS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants