Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CORS in DataLayerView? #1910

Open
hriebl opened this issue Jun 18, 2024 · 4 comments
Open

Enable CORS in DataLayerView? #1910

hriebl opened this issue Jun 18, 2024 · 4 comments

Comments

@hriebl
Copy link

hriebl commented Jun 18, 2024

Hey all,

would it make sense to enable CORS in the DataLayerView, just as in the MapView? This would facilitate the use of GeoJSON data from uMap in other web apps.

By the way, thank you for this great project!

@yohanboniface
Copy link
Member

Makes sense, but I'd wait for:

So we don't break external usage by mistake.

@almet
Copy link
Member

almet commented Jun 25, 2024

Thanks for your issue :-)

The frontier between public and internal data is a bit fuzzy as it is right now. Exposing the internal data to the public can be misleading, so I would too advocate for having a REST API (#175).

@hriebl
Copy link
Author

hriebl commented Jun 25, 2024

Alright, thank you! I was hoping for a quicker solution by just enabling CORS for the existing DataLayerView, but I agree that from a strategic point of view, a general, public REST API should come first. And of course, although enabling CORS for the DataLayerView probably wouldn't do a lot of harm, it might look like an invitation to use it as a stable, public endpoint to some (me, for example 😛).

@davidbgk
Copy link
Contributor

Let's not forget that we need to switch to UUID first 😅

#905

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants