Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct link to a POI #1893

Closed
Cyril5C opened this issue Jun 13, 2024 · 11 comments
Closed

Direct link to a POI #1893

Cyril5C opened this issue Jun 13, 2024 · 11 comments

Comments

@Cyril5C
Copy link

Cyril5C commented Jun 13, 2024

Hello,
I'd like to have what's called a "share" link for POIs. When this link is clicked, the map loads with the POI panel open.
Thanks a lot!
NB: perhaps this is already possible via a geek trick ;)
Cyril.

@yohanboniface
Copy link
Member

It's already possible, but will be refactor soon.

For now, you have to set an identifier key (a name of a column):

image

Then right-click on a feature:

image

@Cyril5C
Copy link
Author

Cyril5C commented Jun 17, 2024

Ok great! It works well except when you have defined a "panel on load". But i guess it's not a priority bug as you are in the middle of a refacto.
Thanks.

@Cyril5C
Copy link
Author

Cyril5C commented Jun 17, 2024

arf and it doesn't work on mobile... for exemple : https://umap.openstreetmap.fr/fr/map/cafe-comptoir_1014832?feature=rectC21sHWLMEeBaa (works on my mac but not on my iPhone)

@yohanboniface
Copy link
Member

Ok great! It works well except when you have defined a "panel on load"

We could give priority to the feature in that case, I think it makes sense.

arf and it doesn't work on mobile

Can you be more explicit ?

@Cyril5C
Copy link
Author

Cyril5C commented Jun 21, 2024

when i open the link on mobile the panel does not open

@yohanboniface
Copy link
Member

BTW, just having a look at your map, have you tried setting a filter key like this ?

image

@Cyril5C
Copy link
Author

Cyril5C commented Jun 21, 2024

ooh ! mais non c'est génial !

@yohanboniface
Copy link
Member

Avec un filtre sur le prix aussi:

image

@Cyril5C
Copy link
Author

Cyril5C commented Jun 24, 2024

Merci pour le petit coup de pouce sur les filtres, par contre les filtre "number" ne marchent par avec des chiffres avec des virgules, j'ai contourné en dupliquant le champ et en remplacant la virgule par un point. Mais pour les français ca serait bien d'accepter les points et les virgule.
C'est top de voir uMap progresser de jour en jour !

@yohanboniface
Copy link
Member

Numbers formatting depends on the locale (eg. in the US a , is a thousand separator: 10,323,234).

We can display a number according to user locale, but there is not helper in the browser for parsing according to locale, plus we don't know the locale used when the number was typed.

So at this stage the only solution I see is to use "machine ready" numbers in the data, and:

  • use a localized version for displaying it, so it's more user friendly
  • when (if) we add typing of columns, allow to define an input format, so users can also type the number in their locale

@yohanboniface
Copy link
Member

(Closing the original issue as it's fixed, and the number related discussion is about typing, which is another story)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants