Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config so users can upload images in the description field #1849

Open
virgile-dev opened this issue May 22, 2024 · 7 comments
Open

Add config so users can upload images in the description field #1849

virgile-dev opened this issue May 22, 2024 · 7 comments

Comments

@virgile-dev
Copy link

Is your feature request related to a problem? Please describe.
To add an image to a feature you need to host it elsewhere. Many options are out there (github, wordpress, Imgr etc.).
The issue is not all users are saavy enough to find the right link that will allow image the image to render (with nextcloud the link is kinda hard to find) and using the Image : {{http://image.url.com}} syntax can be a bit tricky.

Describe the solution you'd like
I'd like uMap to have a configuration variable so that an admin can setup a storage for the user's images (ex: S3)
I'd like uMap to have an interface that allows users to understand how to add an image in their description (ex : Drag and Drop in the text field (like Github) or even and a button with a photo Icon (which would lead us to actually having a rich text editor like Quill.js)
Describe alternatives you've considered
See above how users find solution.

Additional context
This would not have to be setup on every instance and be at the admin discretion.

@davidbgk
Copy link
Contributor

This is not a technical problem but an editorial one, hosting images bring a whole class of new issues:

  1. who will moderate that content? (under which rules/juridictions?)
  2. who will be hold responsible for unmoderated content?
  3. how not to host malware and such with trusted domains?

@virgile-dev
Copy link
Author

I would argue we already have all of these problems without the convenience for uMap users because many users already find ways to display images on their uMap we just not hosting them.

@cquest
Copy link
Contributor

cquest commented May 29, 2024

If uMap hosts pictures, those pictures can be reused elsewhere, not only in uMap.

This is also a problem regarding moderation / liability.

@yohanboniface
Copy link
Member

I don't think uMap itself will host pictures.

What I can see as a plan is to make uMap support an S3/minio API. So each instance could decide to activate or not picture loading, and if yes provide the S3/Minio credential/URL, and when configured uMap will allow users to add pictures in descriptions, and then just drop the images there.

This is what is done in the pads for instance.

@virgile-dev
Copy link
Author

That makes perfect sens @yohanboniface and I'm guessing that instances that let users create map anonymously or don't have a secure way to verify users' identity, like a SSO, won't probably activate it !

@Aurelie-Jallut we might need your input on the UX side of things. uMap doesn't have a rich text editor so do we expect user to just drag and drop and image or should we add an icon that open a file system window so the user can browse its files ?

@Aurelie-Jallut
Copy link
Contributor

I've never used drag and drop in a pad !!
It's good to allow it, of course, but the icon is the clearest thing, it seems to me.

@yohanboniface
Copy link
Member

To keep an eye on: https://github.com/betagouv/communautech/issues/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants