Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent h26x from letting through invalid frames after frame loss #121

Open
jrsnen opened this issue Mar 25, 2022 · 4 comments
Open

Prevent h26x from letting through invalid frames after frame loss #121

jrsnen opened this issue Mar 25, 2022 · 4 comments
Labels
feature New feature

Comments

@jrsnen
Copy link
Member

jrsnen commented Mar 25, 2022

I think at least one designed feature was to drop inter frames until the next intra in case of lost frames, but at the moment, this does not seem to prevent invalid frames from getting through (inter frames refer to previous intra frame and cannot be displayed if a previous frame or an intra frame is missing).

@jrsnen
Copy link
Member Author

jrsnen commented Mar 25, 2022

It would also be nice if this feature was hidden behind a flag.

@jrsnen jrsnen added untested Something that has high likelyhood of not working and removed feature New feature labels Mar 29, 2022
@jrsnen
Copy link
Member Author

jrsnen commented Mar 29, 2022

I'm actually unsure at this point whether this works currently already. Further testing should be on what happens when the network drops packets. There is supposed to be this feature that drops all undecodable frames. I would suggest fixing #105 before testing (working on it currently).

@jrsnen jrsnen changed the title h26x lets through invalid frames due to lost frames h26x may let through invalid frames due to lost frames Mar 30, 2022
@jrsnen jrsnen closed this as completed Mar 31, 2022
@jrsnen jrsnen reopened this Mar 31, 2022
@jrsnen jrsnen added feature New feature and removed untested Something that has high likelyhood of not working labels Jun 17, 2022
@jrsnen
Copy link
Member Author

jrsnen commented Jun 17, 2022

There is a simple version of this in the master, but it is not yet a complete solution (removed the old system which did not work). It can be disabled with a flag.

@jrsnen
Copy link
Member Author

jrsnen commented Jul 8, 2022

I disabled the current system by default because it won't work with non-monotonic timestamps, and it is not yet completed.

@jrsnen jrsnen modified the milestones: Release 2.2, Release 2.1 Jul 9, 2022
@jrsnen jrsnen removed this from the Release v2.1.1 milestone Jul 18, 2022
@jrsnen jrsnen changed the title h26x may let through invalid frames due to lost frames Prevent h26x from letting through invalid frames after frame loss Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

No branches or pull requests

1 participant