Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot commit messages sometimes violate commitlint max-header-length #8

Open
TimoGlastra opened this issue Dec 31, 2019 · 1 comment

Comments

@TimoGlastra
Copy link
Member

TimoGlastra commented Dec 31, 2019

Dependabot commit messages enforce the max-header-length rule from commitlint and will wrap commit messages to keep them below 72 characters. Unfortunately when merging the pr's from dependabot the pr number gets added to the commit messages. If a the header-length of a commit message was exactly 72 characters long it will now exceed the limit.

See dependabot/feedback#165 (comment)

@TimoGlastra
Copy link
Member Author

Dependabot team is open to add config to set the max-header-length, but don't have the time to do at the moment. Corresponding issue: https://github.com/dependabot/feedback/issues/817

TimoGlastra added a commit that referenced this issue Apr 20, 2020
dependabot sometimes creates commit messages that violate this rule. nothing we can do about it at the moment. see #8
TimoGlastra added a commit that referenced this issue Apr 20, 2020
dependabot sometimes creates commit messages that violate this rule. nothing we can do about it at the moment. see #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant