LTD-5696: Update licence decisions bdd tests #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make them concise with limited actions rather than a series of steps
Remove unused step definitions
kevincarrogan
approved these changes
Dec 3, 2024
markj0hnst0n
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Make them concise with limited actions rather than a series of steps.
Bulk of the changes are moving common steps into
conftest.py.Most of the steps such as issuing, refusing, appealing application etc are common with
applications.featurehowever in this case we also need to verify theidof generated licence decisions and licences. For this purpose.save()is overridden to create them with theidwe want. To be able to reuse the steps these are hardcoded in the mock method rather than specifying them as parameters to the steps.LTD-5696