Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API tokens are written to logs #20

Open
reallyrandom opened this issue Jan 13, 2021 · 0 comments
Open

API tokens are written to logs #20

reallyrandom opened this issue Jan 13, 2021 · 0 comments

Comments

@reallyrandom
Copy link

reallyrandom commented Jan 13, 2021 •
edited
Loading

The following log line records API keys in plain text

[D 2021-01-13 21:16:04.593 JupyterHub fargatespawner:351] Request response ...

JUPYTERHUB_API_TOKEN
JPY_API_TOKEN

I believe this is the line writing the log:
https://github.com/uktrade/fargatespawner/blob/master/fargatespawner/fargatespawner.py#L203

run_response = await _run_task(self.log, self._aws_endpoint(), self.get_run_task_args(self))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reallyrandom