Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRO]: Tippy stops working when using @tiptap-pro/extension-drag-handle at 2.17.3 version #6077

Open
vsemak opened this issue Jan 31, 2025 · 1 comment
Labels
Category: Pro The issue or pull request is related to the pro packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug

Comments

@vsemak
Copy link

vsemak commented Jan 31, 2025

Affected Packages

extension-drag-handle

Version(s)

2.17.3

Description of the Bug

When using DragHandle on version 2.17.3 tippy raises warnings in console about using setProps on destroyed instance of tippy.

2.17.2 - works
2.17.3 - dont work

Problem: tippy drag handle element is not positioned properly and has no draggable functionality.

Browser Used

Chrome

Code Example (Preferred)

No response

Expected Behavior

Tippy should work - drag handle should be positioned at node position.

Additional Context (Optional)

Code to reproduce in Angular.

import {DragHandlePlugin} from '@tiptap-pro/extension-drag-handle'
import {AngularRenderer} from "ngx-tiptap";
import {EditorDragHandleComponent} from "../components/editor-drag-handle/editor-drag-handle.component";
import {Injector} from "@angular/core";
import {Extension} from "@tiptap/core";

export const CustomDragHandleExtension = (injector: Injector) => Extension.create({
  name: 'customDragHandle',

  addProseMirrorPlugins() {

    return [
      DragHandlePlugin({
        pluginKey: 'myDragHandle',
        editor: this.editor,
        element: new AngularRenderer(EditorDragHandleComponent, injector, {editor: this.editor}).dom,
        tippyOptions: {
          offset: [-2, 16],
          zIndex: 99,
        },
        onNodeChange: ({node, editor, pos}) => {
        },
      }),
    ]
  },
})
`

### Dependency Updates

- [x] Yes, I've updated all my dependencies.
@vsemak vsemak added Category: Pro The issue or pull request is related to the pro packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Jan 31, 2025
@rushiedeh3dehde
Copy link

Deprecated NgxTiptap and Tippy.js warnings
The deprecation warning for NgxTiptapModule and the associated memory leak warnings from Tippy.js (setProps(), show(), and hide() being called on destroyed instances) suggest a potential issue with how Tippy.js instances are being managed in your code. Since NgxTiptapModule issue is specific to the TiptapBubbleMenu when we remove TiptapBubbleMenu then CustomDragHandleExtension its working well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Pro The issue or pull request is related to the pro packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

No branches or pull requests

2 participants